[miniDLNA] plugin: small configuration script improvment proposale

    • OMV 2.x
    • [miniDLNA] plugin: small configuration script improvment proposale

      Hello there,
      This is my first post on this forum and I'm not sure I'm on the right thread, but I only want to propose a small improvement in OMV miniDLNA plugin.
      Why this code ?
      Because I'm using my own made version of minidlna with my own parameters, I really dislike the way how configuration file is updated from OMV: it is a really simple minidlna.conf that is generated each time a modification is done.
      So, attached code is performing only parameters replacement following OMV parameters instead of generating a new configuration file.
      By this way, if your are using your own setting (for cover name for example, etc), they are not removed if you're adding your shared path from OMV interface.
      The only missing thing is to clean initial minidlna.conf file from example/default shared path.

      Works with openmediavault-minidlna package version 1.1

      File path is /usr/share/openmediavault/mkconf
      File name minidlna (without .txt extension)
      Files
      • minidlna.txt

        (3.54 kB, downloaded 338 times, last: )
    • Fuli wrote:

      I really dislike the way how configuration file is updated from OMV: it is a really simple minidlna.conf that is generated each time a modification is done.

      I do not maintain this plugin, but this is the generic way how config generation is handled in OMV. The config is fully build based on the information that is stored in the config database. That's how it works, OMV is the master of the config files. I understand that some users do not like this, but in this case maybe webmin would be the prefered and better solution (if this fullfills the other requirements why you've choosen OMV).

      P.S.: If you look on your code you should understand why OMV does not work your suggested way, the code is really unmaintainable.
      Absolutely no support through PM!

      I must not fear.
      Fear is the mind-killer.
      Fear is the little-death that brings total obliteration.
      I will face my fear.
      I will permit it to pass over me and through me.
      And when it has gone past I will turn the inner eye to see its path.
      Where the fear has gone there will be nothing.
      Only I will remain.

      Litany against fear by Bene Gesserit
    • I am the maintainer of that plugin and agree with Volker. I like how the config is rewritten each time. It would be MUCH more difficult to maintain plugins if we had no clue what options users were putting in their config files.

      If you want an option in the config written differently, file an issue here.
      omv 4.1.15 arrakis | 64 bit | 4.15 proxmox kernel | omvextrasorg 4.1.13
      omv-extras.org plugins source code and issue tracker - github

      Please read this before posting a question and this and this for docker questions.
      Please don't PM for support... Too many PMs!