Can't create SharedFolder with same Path with OMV3 but with OMV2 yes

TheBlackReverand · 8. August 2016

Hello,

I migrate my OMV2 to OMV3 and all works fine except 1 shared folder.

I have many HDD with the same folder inside, all my HDD are in a pool with mhddfs.
I want have an acces of folder for a specific HDD.

I'm not good in english, a small diagram can help
HDD_1 2To => myFolder
HDD_2 2To => myFolder

myMHDDFSPool => 4To => myFolder (combination of myFolder HDD_1 and myFolder HDD_2)

Shared Folders
=> myFolder ; myMHDDFSPool\myFolder
=> myFolder_HDD_1 ; HDD_1\myFolder

This configuration works fine with OMV2 but not with OMV3

You can this message in attachments.

Please can you say me if it's normal (so I lose a functionality) or if it's a bug/regression?

Thanks for help

votdev · 8. August 2016

OMV3 is more restrictive with shared folders, their names and relativ paths. See https://github.com/openmediava…ed/rpc/sharemgmt.inc#L267.

TheBlackReverand · 8. August 2016

thanks for answer, that's sad, I liked this possibility

Now I can't have a folder with all series and another with only current series. Thanks for your work.

tha-frog · 31. August 2016

Yes,
I found the same problem today.
I tried to share the root (/)of different hard disks, and got the same error.
Why?
Because: An object with the property 'reldirpath' and value '/' already exists.'
It's not allowed to create more than 1 share with the same relative path?

// Check uniqueness:
// - The share name must be global unique because the name
// is also used when exporting a shared folder via NFS
// for example.
OK, this I understand, for sure.
// - The mount directory must be unique, too.
Sorry, I don't understand why. For NFS? No.

root@ThecusN5550-OMV:~# showmount -e 192.168.1.88
Export list for 192.168.1.88:
/export *
/export/WDGreen1TB-1 *
/export/3TB_1-Daten *
("WDGreen1TB-1" and "3TB_1-Daten" are the "share names")

My Solution:
I commented out line 274 in /usr/share/openmediavault/engined/rpc/sharemgmt.inc to
// $db->assertIsUnique($object, "reldirpath");

I can't see why this should be a bad idea, anyone of you can tell me?

Regards from Germany
tha-frog

ryecoaaron · 1. September 2016

If you can't share the root of more than one drive, that is a bug. File at bugtracker

tha-frog · 1. September 2016

Hellp
ryecoaaron

when you see what say

votdev:

OMV3 is more restrictive with shared folders, their names and relativ paths. See github.com/openmediavault/open…ed/rpc/sharemgmt.inc#L267

Than it's not a bug, it's a more restrictive feature.
But if nobody knows why, than it's better to change.

ryecoaaron · 1. September 2016

That @ symbol is causing the code to fail. That is a bug. Not being able to use the same path on multiple shares, that is a restrictive feature. There is still a bug in that code as well since you can't have shared folders created that use the same path even if on different drives.

Either way, someone needs to file a bug report. I would prefer if it wasn't me doing that.

tha-frog · 2. September 2016

I can't understand what you mean.

You say
"That @ symbol is causing the code to fail. That is a bug."
-> Which @ symbol? Where? Which file, which line?

You say
"Not being able to use the same path on multiple shares, that is a restrictive feature."
-> With "path" you mean the name of the share?
Thats correct, each share has to have a unique name.

You say
"There is still a bug in that code as well since you can't have shared folders created that use the same path even if on different drives."
-> This will be done by line 274 in /usr/share/openmediavault/engined/rpc/sharemgmt.inc
$db->assertIsUnique($object, "reldirpath");
-> And this themes to be a feature, not a bug.
"reldirpath" is "/" for the root of a drive
Thats why I have uncommented this line.

ryecoaaron · 2. September 2016

I didn't debug the code to figure out where the problem is. There are definitely a couple of bugs. The @ symbol seems to be causing the data model verification routine to fail hence the error. I'm sure @votdev would know right where the problem is.

With path, I did not mean the share name. If you create a shared folder named test3 on drive1 with a path of test/ and then try to create a shared folder named test4 on drive2 with a path of test/, it fails. It is just looking at short path (not full path) for uniqueness.

Can't create SharedFolder with same Path with OMV3 but with OMV2 yes

Jetzt mitmachen!

Tags