Broken confdbadm while trying to develop on openmediavault-autoshutdown

yo1frenchtoast · 8. September 2017

Hello,

I have an issue after I modified some js script in /var/www/openmediavault/js/omv/module/admin/service/autoshutdown/Settings.js to add forced up days
I reverted to default but it seems that omv database is broken

Code

root@openmediavault:~# omv-confdbadm read conf.service.autoshutdown
Traceback (most recent call last):
  File "/usr/sbin/omv-confdbadm", line 66, in <module>
    sys.exit(main())
  File "/usr/sbin/omv-confdbadm", line 63, in main
    return cmd_inst.execute(*sys.argv)
  File "/usr/share/openmediavault/confdbadm/commands.d/read.py", line 62, in execute
    objs = db.get(cmd_args.id, cmd_args.uuid)
  File "/usr/lib/python3/dist-packages/openmediavault/config/database.py", line 79, in get
    query.execute()
  File "/usr/lib/python3/dist-packages/openmediavault/config/database.py", line 674, in execute
    self._response = self._elements_to_object(elements)
  File "/usr/lib/python3/dist-packages/openmediavault/config/database.py", line 448, in _elements_to_object
    result.set_dict(self._element_to_dict(elements[0]), False)
  File "/usr/lib/python3/dist-packages/openmediavault/config/object.py", line 197, in set_dict
    self.set(key, value, validate)
  File "/usr/lib/python3/dist-packages/openmediavault/config/object.py", line 171, in set
    self.assert_exists(name)
  File "/usr/lib/python3/dist-packages/openmediavault/config/object.py", line 143, in assert_exists
    (name, self.model.id))
openmediavault.exceptions.AssertException: The property 'days-tuesday' does not exist in the model 'conf.service.autoshutdown'.

Alles anzeigen

If I try to recreate, I get a permission error

Code

root@openmediavault:~# omv-confdbadm create conf.service.autoshutdown
ERROR: Failed to create the default configuration: [Errno 13] Permission denied

I also tried to remove openmediavault and install it back, same issue

Does someone have an idea how to fix this ? Thx by advance

ryecoaaron · 8. September 2017

Do you have a github repo of what code you changed? Hard to help otherwise.

yo1frenchtoast · 11. September 2017

Zitat von ryecoaaron

Do you have a github repo of what code you changed? Hard to help otherwise.

Unfortunately no, I just added buttons to autoshutdown plugin in order to add forced up days, something like that :

Code

items: [{
                    xtype: 'checkbox',
                    name: 'days-sunday',
                    fieldLabel: _('Sunday'),
                    checked: true
                }, {
                    xtype: 'checkbox',
                    name: 'days-monday',
                    fieldLabel: _('Monday'),
                    checked: true
                }, {
                    xtype: 'checkbox',
                    name: 'days-tuesday',
                    fieldLabel: _('Tuesday'),
                    checked: true
                }, {
                    xtype: 'checkbox',
                    name: 'days-wednesday',
                    fieldLabel: _('Wednesday'),
                    checked: true
                }, {
                    xtype: 'checkbox',
                    name: 'days-thursday',
                    fieldLabel: _('Thursday'),
                    checked: true
                }, {
                    xtype: 'checkbox',
                    name: 'days-friday',
                    fieldLabel: _('Friday'),
                    checked: true
                }, {
                    xtype: 'checkbox',
                    name: 'days-saturday',
                    fieldLabel: _('Saturday'),
                    checked: true
                }]

Alles anzeigen

I modified datamodels to add variables, it worked until I changed the type from days-xxxx to updays-xxx, it broke after that

So I reverted all files to default (from plugin master branch https://github.com/OpenMediaVa…enmediavault-autoshutdown), but it keeps crashing, like it's still looking for the datamodel of the now inexistant buttons

yo1frenchtoast · 11. September 2017

I temporarily "fixed" the problem by re-adding datamodels :

Code

/usr/share/openmediavault/datamodels/conf.service.autoshutdown.json


    46			"uphours-end": {
    47				"type": "integer",
    48				"minimum": 0,
    49				"maximum": 23,
    50				"default": 20
    51			},
    52	        	"days-monday": {
    53	            		"type": "boolean",
    54	            		"default": false
    55	        	},
    56			"days-tuesday": {
    57				"type": "boolean",
    58				"default": false
    59			},
    60			"days-wednesday": {
    61				"type": "boolean",
    62				"default": false
    63			},
    64			"days-thursday": {
    65				"type": "boolean",
    66				"default": false
    67			},
    68			"days-friday": {
    69				"type": "boolean",
    70				"default": false
    71			},
    72			"days-saturday": {
    73				"type": "boolean",
    74				"default": false
    75			},
    76			"days-sunday": {
    77				"type": "boolean",
    78				"default": false
    79			},
    80			"nsocketnumbers": {
    81				"type": "string",
    82				"default": "21,22,80,139,445,3689,6991,9091,49152"
    83			},

Alles anzeigen

root@openmediavault:/usr/share/openmediavault/datamodels# omv-confdbadm read conf.service.autoshutdown
{"checkclockactive": true, "hddiocheck": true, "sleep": 180, "days-tuesday": false, "days-friday": false, "days-sunday": false, "checksamba": true, "days-monday": false, "uphours-begin": 4, "uldlrate": 50, "uldlcheck": true, "days-thursday": false, "nsocketnumbers": "21,22,80,443,445,8077,8078,8201,9091,32400,58050,58051", "extraoptions": "FORCE_NIC=eth2\nPINGLIST=/root/lib/PINGLIST", "days-saturday": false, "verbose": false, "fake": true, "loadaveragecheck": true, "shutdowncommand": 2, "uphours-end": 5, "syslog": true, "checkcli": true, "cycles": 6, "enable": true, "days-wednesday": false, "loadaverage": 40, "hddiorate": 401, "range": "17"}

ryecoaaron · 11. September 2017

Zitat von yo1frenchtoast

So I reverted all files to default (from plugin master branch github.com/OpenMediaVault-Plug…enmediavault-autoshutdown), but it keeps crashing, like it's still looking for the datamodel of the now inexistant buttons

You need to fix the xml in config.xml. Purging the plugin and re-installing would be the best way to do that.

If you want help on this, please fork the plugin and commit code changes to a github repo. It is much easier to see what changes you made that way.

yo1frenchtoast · 11. September 2017

Zitat von ryecoaaron

You need to fix the xml in config.xml. Purging the plugin and re-installing would be the best way to do that.
If you want help on this, please fork the plugin and commit code changes to a github repo. It is much easier to see what changes you made that way.

That fixed the issue, thank you very much !

I now understand how it works, I will be able to continue my modification on the plugin

Jetzt mitmachen!