Docker GUI plugin now stable
-
- OMV 2.x
- nicjo814
-
-
I've looked at the code and it should be the icons located in images/<add|edit|delete> which I believe to be "standard" icons in OMV. I have to admit though that they look weird in your screenshot.
-
I've looked at the code and it should be the icons located in images/<add|edit|delete> which I believe to be "standard" icons in OMV. I have to admit though that they look weird in your screenshot.
Makes me think....I am the only one seeing it like that then? I tend to zoom out my screen for better fit. But that ss is 100%
-
I can have a look at my dev system when I get back home from work.
-
-
Makes me think....I am the only one seeing it like that then? I tend to zoom out my screen for better fit. But that ss is 100%
For me the icons also look that way:
Greetings Hoppel
-
-
I think I misunderstood the issue Thought it was the wrong images, but you were referring to the width of the buttons right?
-
but you were referring to the width of the buttons right?
Yes, i mean the buttons look odd, i didn't know if it was css, the new theme or whatever. If i switch to old gray theme buttons look ok. So there is an issue with the fix width.
Without the fix width the buttons still look ok in old triton
-
Ya was going to chime in, mine look off too. I just took it as a UI thing that was likely known but not high priority. Good to know I can make a quick manual edit though to fix the look!
-
Hi Guys,
i'm new with docker and also with docker on omv.
But it look it is no a big deal at the moment.thanks for the work on hat plugin.
Is it possible to allow a port range to the container in the omv docker gui?
It looks like docker can handle it docker run -p 7000-8000:7000-8000Cheers Robert
-
Is it possible to allow a port range to the container in the omv docker gui?
It looks like docker can handle it docker run -p 7000-8000:7000-8000I looked at implementing this kind of functionality quite a while back (I would really love it). However back then there was no way to "identify" port ranges via the API. Instead all ports in a range were listed one by one. I can take another look and see if this has changed lately.
-
I looked at implementing this kind of functionality quite a while back (I would really love it). However back then there was no way to "identify" port ranges via the API. Instead all ports in a range were listed one by one. I can take another look and see if this has changed lately.
It would be greate but it is not a priority feature which i need.
Will be a nice feature but if it will come until endo of the year is fast enough for me.Cheers Robert
-
THe api still returns port by port, if you press modify the plugin will parse all the ports line by line, a huge range can make the modify panel look really long. Maybe we can store the port range in a label, same as i did to parse the extra arguments. But honestly this could be easier just to drop down to cli and fire the container manually. We can implement maybe a button to generate the one line run command to copy/paste into terminal where there you can modify the port range.
-
or maybe someone that has golang skills can create a PR at github to change to docker api to return the range in one array.
-
@subzero79 - I think obviously adjustments to code to make it easier/possible is always the best option, but your idea of outputting the run command, could be extremely useful! I just recently ran into this where I was testing a new container, got sidetracked. Sunday came, and my script ran to cleanup non-running containers. I ended up having to rebuilt everything in the console again. If it would be possible to output the run command based on a currently running container and/or to spit it out from a config you've created in the console on demand, that would be fantastic!! It could have saved me since I could easily copy down the run command, and if I start it again via the CLI, the plugin always picks up the details as well. So it could be easy to run it again later and re-manage from the plugin.
Just my two cents, but I could see this being very useful for more than just this port range scenario. The more extensible it is, the easier it becomes for everyone to use.
-
@subzero79
For me it is good enough to geht the port range as an extra argument.But i got an other question:
Should the Docker Service be shown at the dashboard -> services? -
@subzero79
For me it is good enough to geht the port range as an extra argument.But i got an other question:
Should the Docker Service be shown at the dashboard -> services?it should, following the logic that is a daemon. Can you submit a pr with the change? You can mimic any other plugin that involves a service/daemon.
-
Ok, so it took a lot of head scratching and learning. But I think I was able to find what was needed, and test it locally. Hopefully did this in the right place, but the PR is in.
https://github.com/OpenMediaVa…avault-docker-gui/pull/47
And now I can successfully feel like I'm helping to contribute for once!
-
Can we expect a update to production plugin in omv anytime soon? I'm eager hehe
Sent from my ASUS_Z017DA using Tapatalk
Jetzt mitmachen!
Sie haben noch kein Benutzerkonto auf unserer Seite? Registrieren Sie sich kostenlos und nehmen Sie an unserer Community teil!