[Sensors] OMV-Sensors in OMV 4.1.x

Sorry this is taking so long to port over to OMV4 but my time on this is very limited and there is a heck of a lot of code that needs to be converted.

So far I have a working plugin for CPU temps only. I still need to figure out how to add the extra sub panels, the code (below) was working for OMV3 but I just can't figure out why it is not working under OMV4. I don't want to move on to the other sensors until I have gotten the sub tabs working.

Ext.define("OMV.module.admin.diagnostic.system.plugin.Sensors", {
        extend: "OMV.workspace.panel.RrdGraph",
        alias: "omv.plugin.diagnostic.system.sensors",


        title: _("OMV Sensors"),


        initComponent: function() {
                var me = this;
                me.callParent(arguments);
                me.add(Ext.create("OMV.workspace.panel.RrdGraph", {
                        title: "MotherBoard Temp",
                        rrdGraphName: "mb"
                }));
        }
});

Oh I didn't realize that you were working on this as well. If you haven't found this on your own by now, have a look at /usr/share/openmediavault/mkrrdgraph/plugins.d. It appears that graphs are now handled by Python scripts stored in this directory. I believe I also have some commits that I can submit pull requests to you for to help out.

I have uploaded what i have so far to git hub, like I said its working but only for cpu. Its using the new python method to get the graphs but needs the sub tabs sorted out.

Quote from jhmiller

I have uploaded what i have so far to git hub, like I said its working but only for cpu. Its using the new python method to get the graphs but needs the sub tabs sorted out.

Are you sure you've pushed everything? I don't see an mkrrdgraph folder in the repo.

Quote from David B

Are you sure you've pushed everything? I don't see an mkrrdgraph folder in the repo.

I don't use a mkrrdgraph folder, just checked your github and can't see it there either? What do you use it for?

Sorry I just got what I think you mean.
I generate /usr/share/openmediavault/mkrrdgraph/plugins.d/sensors.py using the script depending what options are set on the plugin page.

Quote from jhmiller

I don't use a mkrrdgraph folder, just checked your github and can't see it there either? What do you use it for?
Sorry I just got what I think you mean.
I generate /usr/share/openmediavault/mkrrdgraph/plugins.d/sensors.py using the script depending what options are set on the plugin page.

Oh! Okay I understand what you mean now. I will have a look at how to get the tabs working right now. For now, all I've managed to do is fix the uninstall script and replace the plugin icon with what I think is a better one. I realize that those are not really high priority compared to other stuff, but I wanted to get them out of the way. By the way I have a pull request open with all of the changes I am trying to make. My repo does not have a mkrrdgraph file because I didn't get that far, but it looks like thanks to you, I will not have to.

Change of plans: Instead of trying to get tabs working, I am going to look at fixing a problem with the settings page when you try to apply changes.

Error #0:
OMV\ExecException: Failed to execute command 'export PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin; export LANG=C; omv-mkconf sensors balls 2>&1' with exit code '1': Traceback (most recent call last):
  File "/usr/sbin/omv-mkconf", line 82, in <module>
    sys.exit(main())
  File "/usr/sbin/omv-mkconf", line 78, in main
    rc = execute_script()
  File "/usr/sbin/omv-mkconf", line 55, in execute_script
    os.execv(path, [ path ] + __args.args)
OSError: [Errno 8] Exec format error in /usr/share/php/openmediavault/system/process.inc:175
Stack trace:
#0 /usr/share/openmediavault/engined/module/sensors.inc(33): OMV\System\Process->execute()
#1 /usr/share/openmediavault/engined/rpc/config.inc(168): OMVModuleSensors->applyConfig()
#2 [internal function]: OMVRpcServiceConfig->applyChanges(Array, Array)
#3 /usr/share/php/openmediavault/rpc/serviceabstract.inc(123): call_user_func_array(Array, Array)
#4 /usr/share/php/openmediavault/rpc/serviceabstract.inc(149): OMV\Rpc\ServiceAbstract->callMethod('applyChanges', Array, Array)
#5 /usr/share/php/openmediavault/rpc/serviceabstract.inc(565): OMV\Rpc\ServiceAbstract->OMV\Rpc\{closure}('/tmp/bgstatusog...', '/tmp/bgoutputk4...')
#6 /usr/share/php/openmediavault/rpc/serviceabstract.inc(159): OMV\Rpc\ServiceAbstract->execBgProc(Object(Closure))
#7 /usr/share/openmediavault/engined/rpc/config.inc(213): OMV\Rpc\ServiceAbstract->callMethodBg('applyChanges', Array, Array)
#8 [internal function]: OMVRpcServiceConfig->applyChangesBg(Array, Array)
#9 /usr/share/php/openmediavault/rpc/serviceabstract.inc(123): call_user_func_array(Array, Array)
#10 /usr/share/php/openmediavault/rpc/rpc.inc(86): OMV\Rpc\ServiceAbstract->callMethod('applyChangesBg', Array, Array)
#11 /usr/sbin/omv-engined(536): OMV\Rpc\Rpc::call('Config', 'applyChangesBg', Array, Array, 1)
#12 {main}

I will look later, does that error happen on my branch? I have place holder on the sensors script at the top that I keep there to remind me of places files go, it will cause the script to fail if not removed.

Quote from jhmiller

I will look later, does that error happen on my branch? I have place holder on the sensors script at the top that I keep there to remind me of places files go, it will cause the script to fail if not removed.

Oh. And here I was combing through the mkconf file trying to find a problem in the code. It seems that removing the file listing does indeed stop that error from occurring when trying to change settings, but a new one occurs. It looks like somewhere in the code, mkgraph is still being used instead of mkrrdgraph.

Update: Found it! I thought all of the instances of mkgraph were changed in mkconf, but I found that they weren't.

Failed to execute command 'export PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin; export LANG=C; omv-mkconf sensors balls 2>&1' with exit code '2': sed: can't read /usr/sbin/omv-mkgraph: No such file or directory




Error #0:
OMV\ExecException: Failed to execute command 'export PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin; export LANG=C; omv-mkconf sensors balls 2>&1' with exit code '2': sed: can't read /usr/sbin/omv-mkgraph: No such file or directory in /usr/share/php/openmediavault/system/process.inc:175
Stack trace:
#0 /usr/share/openmediavault/engined/module/sensors.inc(33): OMV\System\Process->execute()
#1 /usr/share/openmediavault/engined/rpc/config.inc(168): OMVModuleSensors->applyConfig()
#2 [internal function]: OMVRpcServiceConfig->applyChanges(Array, Array)
#3 /usr/share/php/openmediavault/rpc/serviceabstract.inc(123): call_user_func_array(Array, Array)
#4 /usr/share/php/openmediavault/rpc/serviceabstract.inc(149): OMV\Rpc\ServiceAbstract->callMethod('applyChanges', Array, Array)
#5 /usr/share/php/openmediavault/rpc/serviceabstract.inc(565): OMV\Rpc\ServiceAbstract->OMV\Rpc\{closure}('/tmp/bgstatusCS...', '/tmp/bgoutputVN...')
#6 /usr/share/php/openmediavault/rpc/serviceabstract.inc(159): OMV\Rpc\ServiceAbstract->execBgProc(Object(Closure))
#7 /usr/share/openmediavault/engined/rpc/config.inc(213): OMV\Rpc\ServiceAbstract->callMethodBg('applyChanges', Array, Array)
#8 [internal function]: OMVRpcServiceConfig->applyChangesBg(Array, Array)
#9 /usr/share/php/openmediavault/rpc/serviceabstract.inc(123): call_user_func_array(Array, Array)
#10 /usr/share/php/openmediavault/rpc/rpc.inc(86): OMV\Rpc\ServiceAbstract->callMethod('applyChangesBg', Array, Array)
#11 /usr/sbin/omv-engined(536): OMV\Rpc\Rpc::call('Config', 'applyChangesBg', Array, Array, 1)
#12 {main}

I do not get any errors on my end, I can enable cpu, cpu and cores and add motherboard temps on same graph. All working with no errors.

I just uploaded eveything I have so far, so you or anyone else can check it out and see what they can come up with.

@jhmiller

Can you provide a link to your package?

Quote from gderf

Can you provide a link to your package?

https://github.com/OpenMediaVa…rs/openmediavault-sensors

It is only on github, no deb package as yet due to the issues I have mentioned above.

Quote from jhmiller

https://github.com/OpenMediaVa…rs/openmediavault-sensors
It is only on github, no deb package as yet due to the issues I have mentioned above.

Perhaps I should just upgrade my OMV machine already and install the plugin so that data is being collected even if it is not displaying properly yet.

How do you build your deb files by the way? Do you use the openmediavault.mk file for that? If so, then how?

Quote from David B

How do you build your deb files

I use the openmediavault-developer plugin, very easy to build and install packages.

Quote from jhmiller

I use the openmediavault-developer plugin, very easy to build and install packages.

Oh alright! I did not know that such a plugin existed. Is it in the OMV-Extras repository? I cannot find it.

Quote from jhmiller

https://github.com/OpenMediaVa…rs/openmediavault-sensors
It is only on github, no deb package as yet due to the issues I have mentioned above.

can you let me know, how I could try this new version when already having uninstalled the old one? Just install it again as mentioned earlier in this thread?
Or does the binaries from GitHub need to be copied to the respective places in OMV?

Thanks!

Quote from David B

Is it in the OMV-Extras repository? I cannot find it.

It is in the beta repo. This plugin is very dangerous if you used incorrectly. You can download the plugin and install manually from bintray.

Quote from ryecoaaron

It is in the beta repo. This plugin is very dangerous if you used incorrectly. You can download the plugin and install manually from bintray.

Haha yeah I learned that the hard way. I found it on GitHub, built it, and installed it last night, and while arbitrarily clicking on buttons to figure out what they do, I accidentally upgraded to OMV 5. Fortunately I was working in a VM which I'd just taken a snapshot of so it was no big deal.

Quote from sbocquet

Hi !

Good work both...

From what I have seen, it's probably better and more flexible to imagine a way to get the sensors name by the lm-sensors directories generated, and store it somewhere in a conf file than to hard code all the possible chipset.
Same for the number of core. Maybe have something more dynamic like:

Code

root@home-server:/var/lib/collectd/rrd/home-server# ls | grep cpu
cpu-0
cpu-1
root@home-server:/var/lib/collectd/rrd/home-server# ls | grep cpu| wc -l
2

Just my 2 cts

Display More

Thank you, but the credit definitely goes to @jhmiller. Everything that I've tried to contribute has been fairly useless so far because I do not entirely know what I am doing. I am still willing to play around with this though, so thank you for the advice.

Quote from sbocquet

From what I have seen, it's probably better and more flexible to imagine a way to get the sensors name by the lm-sensors directories generated, and store it somewhere in a conf file than to hard code all the possible chipset.

Yes and no. There are a lot of sensors and not all are of any use on some systems, the script is done in a way that it checks for the common ones first and also where multiple sensors on kown systems it has an order to pick the most likely sensor. I was planning on adding something along those line as a fail safe if the script did not find ANY sensors.

I have now found the issue with the tabs not showing up and it has been fixed but this has led on to another problem

I can now display graphs for everything except system fans, It will show system fans if combined with the cpu fan but will not show it on its own graph(errors when applying.)

Quote from jhmiller

I have now found the issue with the tabs not showing up and it has been fixed but this has led on to another problem

I can now display graphs for everything except system fans, It will show system fans if combined with the cpu fan but will not show it on its own graph(errors when applying.)

What's the problem? I know I haven't been much help so far, but perhaps I can try to solve it?