Request: OMV only partially rewrite /etc/hosts

Nas-turally · Jun 22nd 2020

Hi,

Today, OMV is fully managing /etc/hosts, which means we cannot define custom entries into it. A solution mentioned in this thread suggests to change things at the DNS server level (in dnsmasq or whatever DNS server is used), but this is not always doable or recommendable.

Would it be possible that OMV scripts only change /etc/hosts within some markers within the file? I think OMV already does that in some other file (sorry, can't remember which) where the content is only reset between the two lines # <<<< and # >>>>, letting the other user-specific lines unchanged.

Thank you!

votdev · Jun 22nd 2020

Starting with openmediavault 5.5.3 you can add custom Salt states to modify /etc/hosts. See https://github.com/openmediava…791c466c19d9a2aeba210f949.

To do so add a file called /srv/salt/omv/deploy/hosts/20myentries.sls with the content

YAML

append_custom_hosts:
  file.append:
    - name: "/etc/hosts"
    - text: |
        xxxxxxxxx

Nas-turally · Jun 22nd 2020

So nice, so powerful... Thank you votdev . Yet, my original suggestion looks a little simplier. What do you think about it? Or you may have so many things to do...

For memo (if others were looking for it), a file where OMV is partially writing is /etc/fstab, where the OMV-written part is enclosed between

Code

# >>> [openmediavault]
[... bla bla bla]

# <<< [openmediavault]
[here, is your own fstab mounts]

ryecoaaron · Jun 22nd 2020

you could just a file (/srv/salt/omv/deploy/hosts/20myentries.sls) like the following and then maintain your entries in /etc/hosts2

Code

{% set hosts = salt['cmd.shell']('cat /etc/hosts2') %}
append_custom_hosts:
  file.append:
    - name: "/etc/hosts"
    - text: "{{ hosts }}"

Nas-turally · Jun 22nd 2020

Elegant solution

votdev · Jun 22nd 2020

Quote from Nas-turally

So nice, so powerful... Thank you votdev . Yet, my original suggestion looks a little simplier. What do you think about it?

The commited implementation is the way to go.

gderf · Jun 22nd 2020

Quote from ryecoaaron

you could just a file (/srv/salt/omv/deploy/hosts/20myentries.sls) like the following and then maintain your entries in /etc/hosts2

Does anything else need to be done to make this take effect?

votdev · Jun 22nd 2020

Quote from gderf

Does anything else need to be done to make this take effect?

As usual you need to run omv-salt deploy run hosts.

gderf · Jun 22nd 2020

Thanks!

apveening · Feb 4th 2021

Thanks, just the info I needed for this problem:

https://old.reddit.com/r/linux…led_on_all_raspberry_pis/

ryecoaaron · Feb 4th 2021

Quote from apveening

Thanks, just the info I needed for this problem:

No it isn't. You will break apt-get update if the repo file points to an invalid ip. Just: sudo truncate -s 0 /etc/apt/sources.list.d/vscode.list

RE: Microsoft repo installed on all Raspberry Pi’s

apveening · Feb 4th 2021

Quote from ryecoaaron

No it isn't. You will break apt-get update if the repo file points to an invalid ip. Just: sudo truncate -s 0 /etc/apt/sources.list.d/vscode.list
RE: Microsoft repo installed on all Raspberry Pi’s

Thanks, I first commented out the active line in that file, I just believe in belt and suspenders where some companies are involved. If it breaks apt update, I'll know it got reactivated without my knowledge or permission.

Nas-turally · Dec 2nd 2021

@ryecoaaron : your code is missing double quotes around the {{ hosts }} variable. It should be:

Code

{% set hosts = salt['cmd.shell']('cat /etc/hosts2') %}
append_custom_hosts:
  file.append:
    - name: "/etc/hosts"
    - text: "{{ hosts }}"

Without them, I get the error message: Rendering SLS 'base:omv.deploy.hosts.20perso_hosts2' failed: could not find expected ':'

ryecoaaron · Dec 2nd 2021

Quote from Nas-turally

your code is missing double quotes around the {{ hosts }} variable. It should be:

Sorry, i was just writing a snippet off the top of my head. I didn't test it.

pseudocoder · Dec 26th 2021

The hosts2 solution looks ideal, but unfortunately the newlines are not maintained; I guess reading it into a variable and then outputting again loses them.

However this seems to work fine:

Code

append_custom_hosts:
    file.append:
        - name: "/etc/hosts"
        - source: "/etc/hosts2"

I'm no Salt expert so there may be some hidden gotchas to that.

Request: OMV only partially rewrite /etc/hosts

votdev Jun 22nd 2020

votdev Jun 22nd 2020

Participate now!

Tags