Mounted BorgBackup Repos with mangled archive name on Windows using Samba

GrimDeWitt · 17. September 2020

Hello everyone!

BorgBackup is configured and does its job without any problems. But I would like someone to help me with one little thing.

In the BorgBackup plugin, when adding an archive, we give it the Name/Prefix and other configuration parameters. The plugin then generates a job in /var/lib/openmediavault/borgbackup/daily.d/borgbackup* where the current time is added to the prefix with -{now}, giving each newly created archive a unique name.

Example: backup-2020-09-12T03:33:03

This is all well designed, but on Windows the file must not have the character ":" in its name, so when I Mount this Repo on Windows via Samba it comes up with a mangling of the archive name. The archive now gets its name on Windows via Samba: BQZUVF~T. Everything works, but it is difficult to recognize the name of the archive.

Is there any way to simply avoid this mangling archive names? Is it possible to easily define a new way of creating a archive name?

If you want to suggest me to set "mangled names = yes" in the Samba configuration, that's not the solution for me, because then I can't access the rest of the archive.

Thanks in advance to everyone for the advice.

ryecoaaron · 18. September 2020

Zitat von GrimDeWitt

Is there any way to simply avoid this mangling archive names?

I will look into it but {now} is a borgbackup function. So, I will probably have to write my own code to replace it.

ryecoaaron · 18. September 2020

Changed in 5.1.4. It will look like the following now: Archive name: datetest-18-Sep-2020_06-03-56

GrimDeWitt · 19. September 2020

What else to say but THANK YOU for the quick response.

This proposed change suits me, although I would suggest using format datetest-2020-09-18_06-03-56 instead of datetest-18-Sep-2020_06-03-56 for easier sorting by name when there are many archives in Repo.

Code

-{now:%Y-%m-%d_%H-%M-%S}

And once again, Thank you very much!

ryecoaaron · 19. September 2020

Zitat von GrimDeWitt

his proposed change suits me, although I would suggest using format datetest-2020-09-18_06-03-56 instead of datetest-18-Sep-2020_06-03-56 for easier sorting by name when there are many archives in Repo.

Done. 5.1.5 in the repo.

GrimDeWitt · 21. September 2020

Zitat von ryecoaaron

Done. 5.1.5 in the repo.

It works great. Just the way it suits me.

I hope that other users will also be satisfied with the change.

Once again, thank you very much.

r-atom · 6. Januar 2021

Hi all,

first of all a big thank you for the time you are investing into this plugin! I am new to openmediavault and currently experimenting with the best setup. I have updated to the most recent version today (5.5.21) with the BorgBackup plugin at v5.1.6

Version 5.1.6 should include the fixes described above. However, my backups are still named with the default {now} timestamp including ":" as separator for the timestamp. And I am experiencing exactly the same problem as GrimDeWitt, mounted archives shared over SMB are not displayed properly on a Windows client.

Here is what I do to create a backup: I press the play button in the Archive list of the BorgBackup plugin's UI. The output of the executed command shows that {now} is being used instead of the custom format proposed by GrimDeWitt (see attached screenshot).

I am not familiar with salt so I have no idea when which code is executed, but in the master branch in the GIT repo I found that borgbackup.inc line 402 is not updated to the custom format.

Code

$cmdArgs[] = sprintf('"%s::%s-{now}"', $path, $archive->get('name'));

I didn't run scheduled backups yet. Could there be a difference between manual execution of backups and scheduled backups?

Thanks for your help!

r-atom

GrimDeWitt · 16. Januar 2021

Hello everyone,

So far I only use scheduled backups and they work perfectly. Now I also tried a manually started backup. The same thing happens to me as the r-atom described.

Zitat von r-atom

Could there be a difference between manual execution of backups and scheduled backups?

The difference is there, the scheduled backup generates the name well, while when you start the backup manually it seems to remain the old name format.

Zitat von ryecoaaron

Done. 5.1.5 in the repo.

I would also ask ryecoaaron to correct the way the file name is generated in a manually started backup.

Once again, thank you, ryecoaaron.

ryecoaaron · 17. Januar 2021

Zitat von GrimDeWitt

I would also ask ryecoaaron to correct the way the file name is generated in a manually started backup.

5.1.7 in the repo.

r-atom · 23. Januar 2021

Thank you very much ryecoaaron for this update. I tested 5.1.7 and it works great now!

Mounted BorgBackup Repos with mangled archive name on Windows using Samba

GrimDeWitt 21. September 2020

Jetzt mitmachen!

Tags