Upgrade Scripts for non-interactive major release upgrades (2->3, 3->4, 4->5)

dleidert · 29. Dezember 2020

EDIT: ATTENTION-Before attempting an upgrade please check if the repo of omv-extras has been updated to github (previously it was on bintray) on your installation:

omv-extras repos moving to github

for OMV4 look at post #9

I recently published some information on how to attempt an upgrade from OMV2 to OMV3 including the upgrade to Debian Jessie. I have now written scripts to automate this process for all three major upgrade paths: 2 to 3, 3 to 4, and 4 to 5.

https://github.com/dleidert/openmediavault-upgrade

I put all the knowledge and experience I collected in these scripts as well as tests and fixes for issues to expect as announced by the Debian release notes for each release. The scripts are based on the original omv-release-upgrade script supplied by openmediavault, but are much more sophisticated. I've successfully tested them in different constellations in VMs and managed the successful upgrade from 2 to 3 to 4 to 5. Note, that I cannot test all possible system variations though. So if you are interested in upgrading your system with these scripts and you have an unusual configuration you can let me know beforehand and I'll do my best to recreate the configuration in a VM and test it.

Note that an upgrade attempt of an OMV2 system will only be possible as long as Debian provides repositories for Debian Jessie (8). After the repositories are gone the upgrade path will be closed and you will have to reinstall from scratch.

Before you attempt any upgrade I recommend the following steps:

Make a full backup of your operating system and make sure you know how to play it back in case something awful happens.
Uninstall all unused plugins. Those make the upgrade harder. But if you don't use/need them then don't install them.
Disable all services running on the OMV machine except for SSH. This will prevent any users from trying to access these services during the upgrade process and it will also allow to remount the data partitions/devices with the shared folders, samba shares, etc. as read-only before attempting the upgrade (mandatory at the moment)
If the upgrade attempt is done remotely via SSH I highly recommend to install screen and run the script in a screen session (see below). Otherwise if the SSH connection breaks the console session will close too and the running script will be terminated even if it has not finished and leaves the system broken.
If you are running encryption (especially on the boot device), if you have unusual boot configurations (scripts), if you are running graphical desktop environments, if you have a lot of third party packages installed, or if you want to stay with sysvinit instead of systemd please make sure you read the Debian release notes. In these cases you are probably better off with a manual upgrade or you have to prepare your system before you can run the scripts.

The scripts are kept in branches for each openmediavault major series and are also released with the version accordingly to the major openmediavault version.

OMV2 to OMV3

Branch: https://github.com/dleidert/openmediavault-upgrade/tree/2

Latest sources: https://github.com/dleidert/op…-upgrade/archive/2.tar.gz

Current release: https://github.com/dleidert/op…grade/archive/v2.4.tar.gz

Script name: `omv-release-upgrade-3`

Debian release notes: https://www.debian.org/releases/jessie/releasenotes

OMV3 to OMV4

Branch: https://github.com/dleidert/openmediavault-upgrade/tree/3

Latest sources: https://github.com/dleidert/op…-upgrade/archive/3.tar.gz

Current release: https://github.com/dleidert/op…grade/archive/v3.3.tar.gz

Script name: `omv-release-upgrade-4`

Debian release notes: https://www.debian.org/releases/stretch/releasenotes

OMV4 to OMV5

Branch: https://github.com/dleidert/openmediavault-upgrade/tree/4

Latest sources: https://github.com/dleidert/op…-upgrade/archive/4.tar.gz

Current release: https://github.com/dleidert/op…grade/archive/v4.7.tar.gz

Script name: `omv-release-upgrade-5`

Debian release notes: https://www.debian.org/releases/buster/releasenotes

Installing Screen

Debian Wheezy users (OMV2) have to get the binary package for their architecture from snapshot.debian.org and then install it. Here for amd64:

sudo dpkg -i screen_4.1.0~20120320gitdb59704-7+deb7u1_amd64.deb

Users of later Debian versions can get it via

sudo apt-get install screen

The README.md file supplied with the tarball contains some basic information on how to use screen. But there is plenty of easy to understand documentation out there.

Checking the correct boot device

There is an issue with grub which can break your system after an unattended upgrade procedure. If devices have been changed on the target system the target device to install the grub boot-loader into stored in the debconf database might be wrong. Please test that the device given by

debconf-show grub-pc | grep -w grub-pc/install_devices

is actually the device the grub boot loader is intended to be installed to. If that's not the case run

sudo dpkg-reconfigure -plow grub-pc

and update the device. Otherwise you might end up not being able to boot your system just being shown the following error message:

grub-pc: error: symbol `grub_calloc' not found

If that is the case get a Debian installation CD/USB image, boot it, choose rescue mode, and follow the instructions to re-install the grub boot loader into the correct destination.

Running the script

One needs to get the tarball, unpack it, and run the script. The following shows it for the attempt to upgrade an OMV2 system:

wget -qO- https://github.com/dleidert/openmediavault-upgrade/archive/v2.4.tar.gz | tar -xz

cd openmediavault-upgrade-2.4

sudo ./omv-release-upgrade-3

If anything goes wrong there is a logfile created by the script which you can supply. The logfile is created in the directory from which you run the script and is called omv_release_upgrade_to_<debian_codename>.<date+time>.log. If everything goes to plan there will be a message telling you to restart the system.

For the OMV 2 to 3 upgrade path it is vital that you check your /etc/fstab for devices with an auto mount option but no nofail option before you reboot. Such devices must be present during boot or the system won't boot successfully. There is a script to add the nofail attribute to these mountpoints during the upgrade. However, make double sure before rebooting.

Feedback

Feel free to send me feedback or report issues.

mi-hol · 29. Dezember 2020

First impression is great, do you consider a PR to official repository?

ryecoaaron · 29. Dezember 2020

That is a lot of work. Hopefully it helps people. I will change my post to point to your scripts.

I recommend removing omv-extras before dist-upgrade and re-install after (at least with the 4 to 5 upgrade). Also, if you don't remove omv-extras plugins before the 2 to 3 upgrade, omv-engined will most likely not start causing the upgrade to fail.

dleidert · 29. Dezember 2020

Zitat von mi-hol

First impression is great, do you consider a PR to official repository?

I don't have a problem with that. It is based on the official scripts and has the same license. So it can be given back to the project.

ryecoaaron · 29. Dezember 2020

Zitat von mi-hol

do you consider a PR to official repository?

There is currently no omv-extras code in the official repository (not my choice). These scripts have omv-extras-related items in them.

dleidert · 29. Dezember 2020

Zitat von ryecoaaron

I recommend removing omv-extras before dist-upgrade and re-install after.

I have thought about that. It requires some magic because it shall only be attempted if omv-extras had been installed. If you think this is urgent I will handle it (to be honest the 4to5 script is the least tested one - too many possible variations). But the script actually runs through even in the current order (the same you used).

Zitat von ryecoaaron

Also, if you don't remove omv-extras plugins before the 2 to 3 upgrade, omv-engined will most likely not start causing the upgrade to fail.

Has there been an omv-extras in OMV2? Shall this be removed in pre.d/50-remove-plugins?

ryecoaaron · 29. Dezember 2020

Zitat von dleidert

I have thought about that. It requires some magic because it shall only be attempted if om-vextras had been installed. If you think this is urgent I will handle it (to be honest the 4to5 script is the least tested one - too many possible variations). But the script actually runs through even in the current order (the same you used).

omv-extras 2.x and 3.x had pre upgrade scripts to try to do the right thing. Since OMV 4 never had the omv-release-upgrade framework, omv-extras 4.x does not have these files.

Zitat von dleidert

Has there been an omv-extras in OMV2?

omv-extras has been around since OMV 0.5.

Zitat von dleidert

Shall this be removed in pre.d/50-remove-plugins

I would have to go back and look. I haven't dealt with that code or the 2.x plugins in a long time.

dleidert · 29. Dezember 2020

The pre.d/50-remove-plugins script in the OMV2 branch actually removes every package starting with openmediavault except for openmediavault and openmediavault-keyring. So if these plugins don't have any unusual names the script already cares about them.

For the OMV 3 to 4 path I've read that removal of the plugins wasn't necessary. Therefor this script is disabled for this path. I'd need at least a list of plugins to remove. Or I could remove everything named openmediavault* but not coming from the official repository.

ryecoaaron · 30. Dezember 2020

Zitat von dleidert

The pre.d/50-remove-plugins script in the OMV2 branch actually removes every package starting with openmediavault except for openmediavault and openmediavault-keyring. So if these plugins don't have any unusual names the script already cares about them.

Most of these plugins were available for OMV 2.x - https://omv-extras.org/debian/pool/main/o/

Zitat von dleidert

For the OMV 3 to 4 path I've read that removal of the plugins wasn't necessary. Therefor this script is disabled for this path. I'd need at least a list of plugins to remove. Or I could remove everything named openmediavault* but not coming from the official repository.

There are some differences between OMV 3.x and 4.x plugins. I know personally, I usually didn't increment the plugin version from 3.x to 4.x if it worked on 3.x and 4.x. If the plugin is version 4.x, it most likely will not work on OMV 3.x.

seife · 3. Januar 2021

Hey dleidert, thanks for your awesome upgrade scripts. These really seem like a lot of work. I absolutely love that there are scripts automating this process.

Now maybe you can help me with a little problem upgrading from 4 to 5. The upgrade script failed giving me this error message in the Log.

Code

Setting up openmediavault (5.5.20-1) ...
locale: Cannot set LC_CTYPE to default locale: No such file or directory
locale: Cannot set LC_ALL to default locale: No such file or directory
Creating configuration database ...
Migrating configuration database ...
  Running migration conf_5.0.0
WARNING: The node 'timemachine' already exists at XPath '/config/services/smb/shares/share'.
  Running migration conf_5.0.3
  Running migration conf_5.2.0
  Running migration conf_5.5.0
  Running migration conf_5.5.3
WARNING: The node 'clients' already exists at XPath '/config/system/time/ntp'.
Setting up Salt environment ...
Processing system modifications ...
dpkg: error processing package openmediavault (--configure):
 installed openmediavault package post-installation script subprocess returned error exit status 1
dpkg: dependency problems prevent configuration of openmediavault-diskstats:
 openmediavault-diskstats depends on openmediavault (>= 5.5.12); however:
  Package openmediavault is not configured yet.

dpkg: error processing package openmediavault-diskstats (--configure):
 dependency problems - leaving unconfigured
Errors were encountered while processing:
 openmediavault
 openmediavault-diskstats

Alles anzeigen

I figured I google the issue finding out that people had this problem before upgrading manually and were able to fix this by commenting out the following line in the omg post install script /var/lib/dpkg/info/openmediavault.postinst

Code

omv-salt deploy run --no-color --quiet collectd chrony postfix

After that running that command manually, apt-get update and apt-get upgrade works fine. This all worked out fine but im not getting a GUI (with cleared cache).

Here the summary with the two failed below:

Summary for test.local

-------------

Succeeded: 11 (changed=4)

Failed: 2

-------------

Total states run: 13

Total run time: 2.695 s

Code

----------
          ID: prereq_nginx_service_monit
    Function: salt.state
      Result: False
     Comment: Run failed on minions: test.local
     Started: 15:07:14.611929
    Duration: 406.693 ms
     Changes:   
              test.local:
                  Data failed to compile:
              ----------
                  Rendering SLS 'base:omv.deploy.monit.services.filesystem' failed: Jinja variable list object has no element 0
              ----------
                  Rendering SLS 'base:omv.deploy.monit.services.nginx' failed: Jinja error: Object of type StrictUndefined is not JSON serializable
              Traceback (most recent call last):
                File "/usr/lib/python3/dist-packages/salt/utils/templates.py", line 498, in render_jinja_tmpl
                  output = template.render(**decoded_context)
             ...
              TypeError: Object of type StrictUndefined is not JSON serializable
              
              ; line 34
              
              ---
              [...]
                  - source:
                    - salt://{{ tpldir }}/files/nginx.j2
                  - template: jinja
                  - context:
                      email_config: {{ email_config | json }}
                      notification_config: {{ notification_config | json }}    <======================
                      webadmin_config: {{ webadmin_config | json }}
                  - user: root
                  - group: root
                  - mode: 644
              
              [...]
              ---
              ----------
                  Rendering SLS 'base:omv.deploy.monit.services.omv-engined' failed: Jinja error: Object of type StrictUndefined is not JSON serializable
              Traceback (most recent call last):
                File "/usr/lib/python3/dist-packages/salt/utils/templates.py", line 498, in render_jinja_tmpl
                  output = template.render(**decoded_context)
                ...
              TypeError: Object of type StrictUndefined is not JSON serializable
              
              ; line 33
              
              ---
              [...]
                  - source:
                    - salt://{{ tpldir }}/files/omv-engined.j2
                  - template: jinja
                  - context:
                      email_config: {{ email_config | json }}
                      notification_config: {{ notification_config | json }}    <======================
                  - user: root
                  - group: root
                  - mode: 644
              
              Traceback (most recent call last):
              [...]
              ---
              ----------
                  Rendering SLS 'base:omv.deploy.monit.services.php-fpm' failed: Jinja error: Object of type StrictUndefined is not JSON serializable
              Traceback (most recent call last):
                File "/usr/lib/python3/dist-packages/salt/utils/templates.py", line 498, in render_jinja_tmpl
                  output = template.render(**decoded_context)
                ...
              TypeError: Object of type StrictUndefined is not JSON serializable
              
              ; line 33
              
              ---
              [...]
                  - source:
                    - salt://{{ tpldir }}/files/php-fpm.j2
                  - template: jinja
                  - context:
                      email_config: {{ email_config | json }}
                      notification_config: {{ notification_config | json }}    <======================
                  - user: root
                  - group: root
                  - mode: 644
              
              Traceback (most recent call last):
              [...]
              ---
              ----------
                  Rendering SLS 'base:omv.deploy.monit.services.system' failed: Jinja error: Object of type StrictUndefined is not JSON serializable
              Traceback (most recent call last):
                File "/usr/lib/python3/dist-packages/salt/utils/templates.py", line 498, in render_jinja_tmpl
                  output = template.render(**decoded_context)
                ...
              TypeError: Object of type StrictUndefined is not JSON serializable
              
              ; line 39
              
              ---
              [...]
                  - source:
                    - salt://{{ tpldir }}/files/system.j2
                  - template: jinja
                  - context:
                      email_config: {{ email_config | json }}
                      loadavg_notification_config: {{ loadavg_notification_config | json }}    <======================
                      memory_usage_notification_config: {{ loadavg_notification_config | json }}
                      cpu_usage_notification_config: {{ loadavg_notification_config | json }}
                  - user: root
                  - group: root
                  - mode: 644
              [...]
              ---

Alles anzeigen

Code

----------
          ID: prereq_phpfpm_service_monit
    Function: salt.state
      Result: False
     Comment: Run failed on minions: test.local
     Started: 15:07:15.113160
    Duration: 415.463 ms
     Changes:   
              test.local:
                  Data failed to compile:
              ----------
                  Rendering SLS 'base:omv.deploy.monit.services.filesystem' failed: Jinja variable list object has no element 0
              ----------
                  Rendering SLS 'base:omv.deploy.monit.services.nginx' failed: Jinja error: Object of type StrictUndefined is not JSON serializable
              Traceback (most recent call last):
                File "/usr/lib/python3/dist-packages/salt/utils/templates.py", line 498, in render_jinja_tmpl
                  output = template.render(**decoded_context)
                ...
              TypeError: Object of type StrictUndefined is not JSON serializable
              
              ; line 34
              
              ---
              [...]
                  - source:
                    - salt://{{ tpldir }}/files/nginx.j2
                  - template: jinja
                  - context:
                      email_config: {{ email_config | json }}
                      notification_config: {{ notification_config | json }}    <======================
                      webadmin_config: {{ webadmin_config | json }}
                  - user: root
                  - group: root
                  - mode: 644
              
              [...]
              ---
              ----------
                  Rendering SLS 'base:omv.deploy.monit.services.omv-engined' failed: Jinja error: Object of type StrictUndefined is not JSON serializable
...

Alles anzeigen

Is there a possibility to just run the post install script again or should this be done another way?

Maybe you have an idea what went wrong. Once I fully understand what is happening I can maybe create a pull request for you. Right now im still a little overwhelmed.

seife · 3. Januar 2021

UPDATE: The GUI-login now suddenly showed up without any changes. After login with the following error:

Code

Error #0:
OMV\Exception: Failed to open include file 'js/omv/PluginManager.js'. in /usr/share/php/openmediavault/controlpanel/controlpanelabstract.inc:42
Stack trace:
#0 /usr/share/php/openmediavault/controlpanel/controlpanelabstract.inc(70): OMV\ControlPanel\ControlPanelAbstract->scanFiles('js/omv/PluginMa...', Array)
#1 /usr/share/php/openmediavault/controlpanel/controlpanelabstract.inc(87): OMV\ControlPanel\ControlPanelAbstract->scanFiles('js/omv/PluginMa...', Array)
#2 /usr/share/php/openmediavault/controlpanel/controlpanelabstract.inc(90): OMV\ControlPanel\ControlPanelAbstract->scanDir('js/omv/module/a...', Array, true)
#3 /usr/share/php/openmediavault/controlpanel/controlpanelabstract.inc(90): OMV\ControlPanel\ControlPanelAbstract->scanDir('js/omv/module/a...', Array, true)
#4 /usr/share/php/openmediavault/controlpanel/controlpanelabstract.inc(90): OMV\ControlPanel\ControlPanelAbstract->scanDir('js/omv/module/a...', Array, true)
#5 /usr/share/php/openmediavault/controlpanel/administration.inc(54): OMV\ControlPanel\ControlPanelAbstract->scanDir('js/omv/module/a...', Array, true)
#6 /usr/share/php/openmediavault/controlpanel/controlpanelabstract.inc(208): OMV\ControlPanel\Administration->getJavascriptIncludes()
#7 /var/www/openmediavault/index.php(41): OMV\ControlPanel\ControlPanelAbstract->render()
#8 {main}

Alles anzeigen

ryecoaaron · 3. Januar 2021

Zitat von seife

Failed to open include file 'js/omv/PluginManager.js'.

You still have an OMV 4.x plugin installed. What is the output of: dpkg -l | grep openm

seife · 3. Januar 2021

Zitat von ryecoaaron

You still have an OMV 4.x plugin installed. What is the output of: dpkg -l | grep openm

Ohh yes you are very much correct indeed. I did remove all of them that I was able to. After:

Code

it  openmediavault                      5.5.20-1                              all          openmediavault - The open network attached storage solution
rH  openmediavault-diskstats            5.0.6-1                               all          openmediavault disk monitoring plugin
ii  openmediavault-keyring              1.0                                   all          GnuPG archive keys of the OpenMediaVault archive
ic  openmediavault-omvextrasorg         4.1.16                                all          OMV-Extras.org Package Repositories for OpenMediaVault

Unfortunately I can't remove openmediavault-omvextrasorg with apt-get --purge remove openmediavault-omvextrasorg because:

Code

Errors were encountered while processing: openmediavault-diskstats

Code

apt-get --purge remove openmediavault-diskstats
Reading package lists... Done
Building dependency tree       
Reading state information... Done
The following packages will be REMOVED:
  openmediavault-diskstats
0 upgraded, 0 newly installed, 1 to remove and 0 not upgraded.
1 not fully installed or removed.
After this operation, 114 kB disk space will be freed.
Do you want to continue? [Y/n] Y
(Reading database ... 154564 files and directories currently installed.)
Removing openmediavault-diskstats (5.0.6-1) ...
dpkg: error processing package openmediavault-diskstats (--remove):
 installed openmediavault-diskstats package post-removal script subprocess returned error exit status 1
Errors were encountered while processing:
 openmediavault-diskstats
E: Sub-process /usr/bin/dpkg returned an error code (1)

Alles anzeigen

ryecoaaron · 3. Januar 2021

Zitat von seife

Unfortunately I can't remove openmediavault-omvextrasorg with apt-get --purge remove openmediavault-omvextrasorg because:

I would try the following:

sudo rm /var/lib/dpkg/info/openmediavault-diskstats.postrm

sudo apt-get remove openmediavault-diskstats

sudo apt-get purge openmediavault-omvextrasorg

sudo omv-salt deploy run collectd

seife · 3. Januar 2021

That worked perfectly!

Only one failed in the summary:

Code

----------
          ID: prereq_collectd_service_monit
    Function: salt.state
      Result: False
     Comment: Run failed on minions: test.local
     Started: 16:42:00.794131
    Duration: 394.981 ms
     Changes:   
              test.local:
                  Data failed to compile:
              ----------
                  Rendering SLS 'base:omv.deploy.monit.services.filesystem' failed: Jinja variable list object has no element 0
              ----------
                  Rendering SLS 'base:omv.deploy.monit.services.nginx' failed: Jinja error: Object of type StrictUndefined is not JSON serializable
              Traceback (most recent call last):
                File "/usr/lib/python3/dist-packages/salt/utils/templates.py", line 498, in render_jinja_tmpl
                  output = template.render(**decoded_context)
                ...
              TypeError: Object of type StrictUndefined is not JSON serializable
              
              ; line 34
              
              ---
              [...]
                  - source:
                    - salt://{{ tpldir }}/files/nginx.j2
                  - template: jinja
                  - context:
                      email_config: {{ email_config | json }}
                      notification_config: {{ notification_config | json }}    <======================
                      webadmin_config: {{ webadmin_config | json }}
                  - user: root
                  - group: root
                  - mode: 644
              
              [...]
              ---
              ----------
                  Rendering SLS 'base:omv.deploy.monit.services.omv-engined' failed: Jinja error: Object of type StrictUndefined is not JSON serializable
              Traceback (most recent call last):
                File "/usr/lib/python3/dist-packages/salt/utils/templates.py", line 498, in render_jinja_tmpl
                  output = template.render(**decoded_context)
                ...
              TypeError: Object of type StrictUndefined is not JSON serializable
              
              ; line 33
              
              ---
              [...]
                  - source:
                    - salt://{{ tpldir }}/files/omv-engined.j2
                  - template: jinja
                  - context:
                      email_config: {{ email_config | json }}
                      notification_config: {{ notification_config | json }}    <======================
                  - user: root
                  - group: root
                  - mode: 644
              
              Traceback (most recent call last):
              [...]
              ---
              ----------
                  Rendering SLS 'base:omv.deploy.monit.services.php-fpm' failed: Jinja error: Object of type StrictUndefined is not JSON serializable
              Traceback (most recent call last):
                File "/usr/lib/python3/dist-packages/salt/utils/templates.py", line 498, in render_jinja_tmpl
                  output = template.render(**decoded_context)
               ...
              TypeError: Object of type StrictUndefined is not JSON serializable
              
              ; line 33
              
              ---
              [...]
                  - source:
                    - salt://{{ tpldir }}/files/php-fpm.j2
                  - template: jinja
                  - context:
                      email_config: {{ email_config | json }}
                      notification_config: {{ notification_config | json }}    <======================
                  - user: root
                  - group: root
                  - mode: 644
              
              Traceback (most recent call last):
              [...]
              ---
              ----------
                  Rendering SLS 'base:omv.deploy.monit.services.system' failed: Jinja error: Object of type StrictUndefined is not JSON serializable
              Traceback (most recent call last):
                File "/usr/lib/python3/dist-packages/salt/utils/templates.py", line 498, in render_jinja_tmpl
                  output = template.render(**decoded_context)
                ...
              TypeError: Object of type StrictUndefined is not JSON serializable
              
              ; line 39
              
              ---
              [...]
                  - source:
                    - salt://{{ tpldir }}/files/system.j2
                  - template: jinja
                  - context:
                      email_config: {{ email_config | json }}
                      loadavg_notification_config: {{ loadavg_notification_config | json }}    <======================
                      memory_usage_notification_config: {{ loadavg_notification_config | json }}
                      cpu_usage_notification_config: {{ loadavg_notification_config | json }}
                  - user: root
                  - group: root
                  - mode: 644
              [...]
              ---

Alles anzeigen

Code

    Data failed to compile:
----------
    Rendering SLS 'base:omv.deploy.collectd.plugins.interface' failed: Jinja error: Failed to convert property 'mtu': invalid literal for int() with base 10: ''
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/openmediavault/config/datamodel.py", line 293, in property_convert
    result = int(value)
ValueError: invalid literal for int() with base 10: ''

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/salt/utils/templates.py", line 498, in render_jinja_tmpl
    output = template.render(**decoded_context)
  File "/usr/lib/python3/dist-packages/jinja2/asyncsupport.py", line 76, in render
    return original_render(self, *args, **kwargs)
  File "/usr/lib/python3/dist-packages/jinja2/environment.py", line 1008, in render
    return self.environment.handle_exception(exc_info, True)
  File "/usr/lib/python3/dist-packages/jinja2/environment.py", line 780, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/lib/python3/dist-packages/jinja2/_compat.py", line 37, in reraise
    raise value.with_traceback(tb)
  File "<template>", line 21, in top-level template code
  File "/var/cache/salt/minion/extmods/modules/omv_conf.py", line 83, in get_by_filter
    id_, openmediavault.config.DatabaseFilter(filter_), **kwargs
  File "/usr/lib/python3/dist-packages/openmediavault/config/database.py", line 125, in get_by_filter
    query.execute()
  File "/usr/lib/python3/dist-packages/openmediavault/config/database.py", line 695, in execute
    self._response = self._elements_to_object(elements)
  File "/usr/lib/python3/dist-packages/openmediavault/config/database.py", line 470, in _elements_to_object
    obj.set_dict(self._element_to_dict(element), False)
  File "/usr/lib/python3/dist-packages/openmediavault/config/object.py", line 208, in set_dict
    self.set(key, value, validate)
  File "/usr/lib/python3/dist-packages/openmediavault/config/object.py", line 186, in set
    value = self.model.property_convert(name, value)
  File "/usr/lib/python3/dist-packages/openmediavault/config/datamodel.py", line 303, in property_convert
    "Failed to convert property '{}': {}".format(name, str(e))
ValueError: Failed to convert property 'mtu': invalid literal for int() with base 10: ''

; line 21

---
[...]
#
# You should have received a copy of the GNU General Public License
# along with OpenMediaVault. If not, see <http://www.gnu.org/licenses/>.

{% set interfaces = [] %}
{% for interface in salt['omv_conf.get_by_filter'](    <======================
  'conf.system.network.interface',
  {'operator': 'or', 'arg0': {'operator': 'stringEquals', 'arg0': 'type', 'arg1': 'ethernet'}, 'arg1': {'operator': 'stringEquals', 'arg0': 'type', 'arg1': 'wifi'}}) %}
{% set used_by = salt['omv_conf.get_by_filter'](
  'conf.system.network.interface',
  {'operator': 'stringContains', 'arg0': 'slaves', 'arg1': interface.devicename}) %}
[...]
---

Alles anzeigen

ryecoaaron · 3. Januar 2021

You may need to make some tweaks to your notifications and network interface setup from the web interface to fix that.

dleidert · 3. Januar 2021

Zitat von seife

Code

[..]
Setting up Salt environment ...
Processing system modifications ...
dpkg: error processing package openmediavault (--configure):
 installed openmediavault package post-installation script subprocess returned error exit status 1
dpkg: dependency problems prevent configuration of openmediavault-diskstats:
 openmediavault-diskstats depends on openmediavault (>= 5.5.12); however:
  Package openmediavault is not configured yet.

dpkg: error processing package openmediavault-diskstats (--configure):
 dependency problems - leaving unconfigured
Errors were encountered while processing:
 openmediavault
 openmediavault-diskstats

Alles anzeigen

I figured I google the issue finding out that people had this problem before upgrading manually and were able to fix this by commenting out the following line in the omg post install script /var/lib/dpkg/info/openmediavault.postinst

Code

omv-salt deploy run --no-color --quiet collectd chrony postfix

~~Can someone explain the cause of this issue to me? I searched through the forum but I don't quite get it. It doesn't seem to make a difference if I enable or disable NTP.~~

Ok. After some more reading my impression is that chronyd starts to fail on systems running a kernel with SECCOMP disabled, because the default /etc/default/chrony runs it with seccomp enabled via the -F 1 switch. So I can workaround this by supplying a a configuration file beforehand which disabled the seccomp filter. But I wonder if openmediavault's postinst (and omv-salt) should better take care of this.

dleidert · 3. Januar 2021

I have a workaround to deal with it. Will be fixed in the upcoming 4.2 release.

https://github.com/dleidert/openmediavault-upgrade/issues/3

ryecoaaron · 4. Januar 2021

Zitat von dleidert

I have a workaround to deal with it.

This won't work on RPi systems since they don't put their config file in /boot. You can modprobe configs and zgrep the config from /proc/config.gz though. But I am curious what kernel doesn't have SECCOMP enabled? Debian, proxmox, rpi, and armbian kernels have it enabled.

dleidert · 4. Januar 2021

Custom kernels I guess. I asked the poster who had the issue for kernel information, but didn't receive an answer so far. With the new releases the log file will contain information about the kernel.

Debian systems don't make the config available in /proc/config*. That's why I went with /boot. But I can make a really conservative approach:

test for /proc/config* and use it, else
test for /boot/config-`uname -r` and use it, else
assume seccomp is not avaialble and go with -F 0 (which is the default anyway)

OMV2 to OMV3

OMV3 to OMV4

OMV4 to OMV5

Installing Screen

Checking the correct boot device

Running the script

Feedback

Jetzt mitmachen!