Upgrade Scripts for non-interactive major release upgrades (2->3, 3->4, 4->5)

Zitat von peguerosdc

Thank you for sharing!

However, I tried to upgrade my NanoPi M4 from 4 -> 5 and even though the upgrade seemed to be successful, when I rebooted my device (as told after the script finished), now it has no network (I don't even see it listed in my router's list of clients) and I have no output via HDMI. Guess it's dead and I will have to do a clean install 🤷🏼

I need the upgrade log to check if anything went wrong. About the network:

https://www.debian.org/release…l#migrate-interface-names

About the HDMI output: Do you use special drivers? If yes did you rebuild your kernel module?

Zitat von conker

Hi,

first of all thanks for sharing these scripts.

I casually tried updating OMV4->5 (made a backup beforehand obviously) but ran into problems.

1. script 81 stopped with some dpkg error (salt.exceptions.CommandExecutionError: The shell bash is not available )

2. today I rebooted, that worked at least, dpkg still had some problems, but after a few tries (idk what exactly helped it, autoclean?) it started working again

3. but the web UI still doesn't work, so I tried sudo omv-salt deploy run nginx phpfpm (from RE: OMV 5.0 - finally out! :-))

but I'm still getting weird php errors etc.

(First webUI didn't show at all, now I can login, but I get an error after clicking login)

Idk where to post my stuff, here or in github, what do you prefer ?

Also does that main output log contain any personal info or can I just post it publicly ?

Alles anzeigen

The log doesn't contain personal information. But it contains the whole package list including versions and some environment variables. If you don't want to publish that you can send it to me via PM.

conker, see #12. You probably have an incompatible plugin installed.

Edit (after checking your log): The scripts stopped at the last script in run.d. I don't know what the salt issue is about. But all the scripts in the post.d directory haven't been run at this point. If you have figured out how to fix the salt issue you still have to run these scripts:

sudo run-parts --exit-on-error -v post.d

This should update omvextras and all the plugins.

That's btw the salt error when openmediavault gets upgraded:

Zitat

Setting up Salt environment ...

[ERROR ] An un-handled exception was caught by salt's global exception handler:

CommandExecutionError: The shell bash is not available

Traceback (most recent call last):

File "/usr/bin/salt-call", line 11, in <module>

load_entry_point('salt==3002.2', 'console_scripts', 'salt-call')()

File "/usr/lib/python3/dist-packages/salt/scripts.py", line 449, in salt_call

client.run()

File "/usr/lib/python3/dist-packages/salt/cli/call.py", line 48, in run

caller = salt.cli.caller.Caller.factory(self.config)

File "/usr/lib/python3/dist-packages/salt/cli/caller.py", line 55, in factory

return ZeroMQCaller(opts, **kwargs)

File "/usr/lib/python3/dist-packages/salt/cli/caller.py", line 320, in __init__

super().__init__(opts)

File "/usr/lib/python3/dist-packages/salt/cli/caller.py", line 80, in __init__

self.minion = salt.minion.SMinion(opts)

File "/usr/lib/python3/dist-packages/salt/minion.py", line 926, in __init__

opts["grains"] = salt.loader.grains(opts)

File "/usr/lib/python3/dist-packages/salt/loader.py", line 819, in grains

ret = funcs[key]()

File "/usr/lib/python3/dist-packages/salt/grains/core.py", line 2076, in os_data

grains.update(_linux_gpu_data())

File "/usr/lib/python3/dist-packages/salt/grains/core.py", line 222, in _linux_gpu_data

lspci_out = __salt__["cmd.run"]("{} -vmm".format(lspci))

File "/usr/lib/python3/dist-packages/salt/modules/cmdmod.py", line 896, in _run_quiet

success_retcodes=success_retcodes,

File "/usr/lib/python3/dist-packages/salt/modules/cmdmod.py", line 330, in _run

raise CommandExecutionError(msg)

salt.exceptions.CommandExecutionError: The shell bash is not available

Alles anzeigen

The SHELL environment variable however says that it actually is a bash shell. Is this command maybe executed as a different user and this user has no bash shell? ryecoaaron , any idea about this?

Zitat von conker

Well I guess I have been lucky that the system booted at all xD

now I'm running run-parts --exit-on-error -v post.d

Code

Purging configuration files for openmediavault-omvextrasorg (4.1.16) ...
Cleaning up configuration database ...
/var/lib/dpkg/info/openmediavault-omvextrasorg.postrm: 35: /var/lib/dpkg/info/openmediavault-omvextrasorg.postrm: omv-mkconf: not found
dpkg: error processing package openmediavault-omvextrasorg (--purge):
installed openmediavault-omvextrasorg package post-removal script subprocess returned error exit status 127

No luck. The system had been upgraded successfully. Just a few package had not yet been. None of them critical.

If openmediavault had already been upgraded the omv-mkconf script had been gone already. That's why the post.d/10-reinstall-omvextras script temporarily creates it to avoid this issue:

echo -e '#!/bin/sh\nexit 0' > /usr/sbin/omv-mkconf

Then the openmediavault-omvextrasorg.postrm will run successfully. Then the temporary script can be removed.

Zitat von ryecoaaron

The salt commands are executed as root in the postinst script. I've never seen this error before. Maybe the default root shell needs to be root and someone changed it on their system? votdev

conker, which shell is assigned to root?

I'm testing now with assigning different shells to root.

conker, I'm not able to reproduce it. I can see in your logs that you have rssh installed. I'm therefor interested which shells the current user and root have and if you restrict anything via .ssh/autohorized_keys or if you apply any other restrictions to either the user or the root account.

Zitat von peguerosdc

Now that explains why the network is down! But, still, I can't work on it as I have no HDMI output. I don't use any special drivers.

Tbh I prefer to do a clean installation or to restore from by backup than to try to debug this, but I leave the logs here hoping it helps if someone comes across a similar situation.

Thank you for replying and, again, for sharing the scripts!

Actually I think you are just missing a recent kernel image and hardware support:

Zitat

[..]

The following packages will be REMOVED:

armbian-tools-stretch* linux-dtb-rk3399* linux-image-rk3399*

linux-stretch-root-nanopim4* linux-u-boot-nanopim4-default*

[..]

You probably want to install the correct tools and linux image for ambian buster (just guessing: linux-image-current-rockchip64(?), armbian-firmware, armbian-config). I cannot find any updated package for linux-image-rk3399. So maybe someone can tell you the package names you are looking for. This would also explain the lack of support for the HDMI port.

Also you might want to check what an Armbian upgrade from stretch to buster requires additonally (the scripts cannot cover this). A search engine might help.

The upgrade process itself went without issues according to the log.

Zitat von conker

I'm logged in as root all the time and same in the screen session

Code

root@********-omv:~# echo $SHELL
bash

For me the bash error sounds like maybe the shell package was updated around some of the time, and then the file wasn't available ?

Would you mind checking the shell entry for root in /etc/passwd?

The shells are all updated much earlier. I have no idea why the salt-command throws this error. Next time, if the same error appears, you can try to run the failing command manually without redirecting the output to /dev/null. You can also try to explicitly set the shebang in /var/lib/dpkg/info/openmediavault.postinst to #!/bin/bash and then apt-get install -f.

I just released version 4.7. It fixes a few bugs and also disables the removal of packages without any source reference. This has caused for example the kernel images in #98 to be removed. Although this means that packages will be left which are no longer provided by any repository enabled, it will also prevent the removal of potentially important packages. Instead these packages are now announced at the end of the upgrade process and users will have to remove this kind of cruft on their own.