Backup plugin - Keep the last x days of backups

Hi,

I use backup plugin with scheduled backup jobs (running every 2 days).

There is an option Keep (with description "Keep the last x days of backups"). I have is set to 5, but doesn't seems like old backups are deleted. At the moment I have 7 backups and the oldest is from the 17th of Feb. The only non-standard thing is a different path and additional sub-directory for backups added in /etc/default/openmediavault and it looks like that:

OMV_BACKUP_DIR_NAME="/backups/omvbackup/`date +%y-%m-%d-%H`/"
OMV_BACKUP_FILE_PREFIX="omv__"

which saves a backup to /backups/omvbackup/ and sub-directory with a current date and hour.

Could anyone explain how to set it up to keep only last few backups please?

Thanks

Greg

Yeah. I thought it may be a problem. That's why I mentioned that. Thanks. Will try that.

ryecoaaron - thank will see in a few days then. BTW - Interesting about the 'find' command. Need to read more about it. I actually used it in my cron scripts a while ago to delete old daily, weekly and monthly backups and never had any issues.

I've got it set to 5, but last night just got one more backup without deleting the old one, so I've got 8 of them at the moment. Will wait another 48 hours so see if creating another one will delete the very old one too.

I'm guessing the problem may be the path and sub-directories where the backups are saved as cubemin suggested in a previous post. Will change it in a few days and see.

The result of ls command is nothing. The same with the find command.

However it returns a list of files if I change -maxdepth to 2 (I have it in sub-directories as explained in my first post (also sub-dirs are listed below for you reference.

pi@rpi4:/srv/elements1/backups/omvbackup $ ls
21-02-17-05  21-02-21-05  21-02-25-05  21-03-01-05  dd.txt
21-02-19-05  21-02-23-05  21-02-27-05  21-03-03-05  image-utils
pi@rpi4:/srv/elements1/backups/omvbackup $ ls -al *.grub
ls: cannot access '*.grub': No such file or directory
pi@rpi4:/srv/elements1/backups/omvbackup $ find -maxdepth 1 -type f -mtime +5 -name "*.grub" -ls
pi@rpi4:/srv/elements1/backups/omvbackup $ find -maxdepth 2 -type f -mtime +5 -name "*.grub" -ls
103682651      4 -rw-r--r--   1 root     users         446 Feb 17 05:21 ./21-02-17-05/omv__-17-Feb-2021_05-21-02.grub
103678028      4 -rw-r--r--   1 root     users         446 Feb 19 05:30 ./21-02-19-05/omv__-19-Feb-2021_05-30-01.grub
103682660      4 -rw-r--r--   1 root     users         446 Feb 25 05:30 ./21-02-25-05/omv__-25-Feb-2021_05-30-01.grub
103678039      4 -rw-r--r--   1 root     users         446 Feb 21 05:30 ./21-02-21-05/omv__-21-Feb-2021_05-30-01.grub
103682592      4 -rw-r--r--   1 root     users         446 Feb 23 05:30 ./21-02-23-05/omv__-23-Feb-2021_05-30-01.grub

Happy to modify some file, but I guess they will be restored to 'factory' on the backup plugin update.

May be safer and more reliable if I keep all backups in the same directory. Then it should work straight away.

In meantime is there any place (github?) I can report a bug / request a feature to make it work in a future?

In meantime (before the new version of the plugin will be distributed) based on your changes in Github I added a line:

OMV_BACKUP_MAX_DEPTH="3"

to /etc/default/openmediavault and changed old find line in omv-backup to:

find "${backupDir}" -maxdepth ${OMV_BACKUP_MAX_DEPTH} -type f -mtime +${keep} -name "${OMV_BACKUP_FILE_PREFIX}*" -delete

as you updated it in Github repository.

The backup ran last night. Created a new one, but haven't deleted the old ones.

Will investigate more in the evening when I'm back home, but it seems like the script finds old files in:

backupDir="${sfpath}/${OMV_BACKUP_DIR_NAME}"

but OMV_BACKUP_DIR_NAME in my case is dependant on a current date (and everytime the script runs the dir path if different, thus old files / dirs are not deleted):

OMV_BACKUP_DIR_NAME="/backups/omvbackup/`date +%y-%m-%d-%H`/"

so I guess I need to move date part to file prefix and make it look something like:

OMV_BACKUP_DIR_NAME="/backups/omvbackup/"
OMV_BACKUP_FILE_PREFIX="`date +%y-%m-%d-%H`/omv__"

That will make the script to find old file in .../omvbackup/ dir. However I'm not sure if slash ("/") can be placed as a part of file prefix and if it's going to be recognised as directory name.

Will change the settings and run it manually tonight when get back home and see the result.

Many thanks ryecoaaron for your help with that.

EDIT:

Tried to put a date in the prefix part, but it says No such file or directory:

Failed to execute command 'export PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin; export LANG=C.UTF-8; /usr/sbin/omv-backup 2>&1': Method: ddfull
Device file: /dev/root
Root drive: /dev/mmcblk0
/usr/sbin/omv-backup: line 84: /srv/dev-disk-by-uuid-83a49c51-f71d-4fd0-a4f0-028b95102cd7/backups/omvbackup/21-03-05-19/omv__-05-Mar-2021_19-49-34.fdisk: No such file or directory

The script should make the directory (based on a current date) first

EDIT 2:

Would it be possible to have a different date format in filenames? I personally prefer date +"%y-%m-%d_%H-%M-%S" instead of hardcoded date +"%d-%b-%Y_%H-%M-%S" (better for sorting files by name from the oldest to newest).

Again - I'm going to change it manually for now and don't use sub-dirs, but it will be overwritten on the plugin update.