this clearly wrong.
Why is it wrong? The kernel plugin doesn't remove zfs-dkms after installing the proxmox kernel or removing the debian kernels. zfs-dkms being installed with only the proxmox kernels doesn't actually build the module.
I'm not sure what would change with the upgrade script because apt is just doing what the control file says. On amd64, zfs-dkms will only be installed if the pve-headers package is not installed.
The pvekernel.list is dropped early on in the process, when new versions of the kernel and zfs plugins are installed there's nothing to trigger the installation of pve kernel 6.5 and the upgrade script drags back in dkms
pvekernel.list is removed on purpose - https://github.com/OpenMediaVa…mvextras-sources-list#L38
The upgrade should not install the 6.5 kernel for two reasons.
The script doesn't install dkms. The only thing that should install that are the dependencies in the zfs plugin BUT it should not install zfs-dkms if pve-headers are installed - https://github.com/OpenMediaVa…master/debian/control#L16
I will have to try an upgrade to see what exactly is installing dkms/zfs-dkms. I would *guess* that it is caused by zfs modules being newer in Deb12 than what is currently installed from Deb11/OMV 6.x before the upgrade. This isn't fun to fix since there are so many combos of kernels and architectures that have to be thought of.
If your plan was for people to manually install 6.2/6.5 post update, has that ever been stated anywhere?
I didn't really have a plan. I just had the script remove the repo because I wanted the kernel plugin to setup the proper repo. I just figured most people would have the 6.2 kernel installed already and the system would ok with it after.
There could be a mix of the following:
If someone can fix the upgrade script to accommodate all of those scenarios, I welcome the PR. Until then, I still haven't tried anything.
would applying a post-upgrade fix-script after re-booting into OMV7 be a viable approach for those starting from OMV6 + PVE + ZFS?
Sure. Would the user run this script? Who is going to write it?
The problem is that backports is most likely enabled and backports has a newer version of zfs-zed and zfsutils-linux than what is in the proxmox kernel. When these debian packages are installed, the depend on zfs-dkms.
So, people could disable backports before upgrading (I didn't test that) OR you can fix it after the upgrade with:
omv-changebackports no
apt-get install zfs-zed=2.2.2-pve2 zfsutils-linux=2.2.2-pve2
apt-get purge zfs-dkms dkms
No need to remove the plugin.
This problem will be easier once the proxmox repo has a newer version of zfs.
Display MoreThe problem is that backports is most likely enabled and backports has a newer version of zfs-zed and zfsutils-linux than what is in the proxmox kernel. When these debian packages are installed, the depend on zfs-dkms.
So, people could disable backports before upgrading (I didn't test that) OR you can fix it after the upgrade with:
omv-changebackports no
apt-get install zfs-zed=2.2.2-pve2 zfsutils-linux=2.2.2-pve2
apt-get purge zfs-dkms dkms
No need to remove the plugin.
Your post-upgrade fix fails as there is no pve repo post update. The OMV6/7 upgrade deletes the pve repo and AFAIK the only thing that installs a pve repo on OMV is when omv-installproxmox is run.
The far better option is to disable backports before upgrading OMV6 to OMV7. This streamlines the upgrade, dksm/zfs-dksm are not re-installed and no wasteful dlkms zfs modules build take place.
So in OMV6 at the CLI:
1. omv-changebackports no
2., omv-release-upgrade
3. re-boot
After the first re-boot into OMV7 you will still need to
1. Install pve kernel 6.2 or 6.5 in order that the pve repo is installed.
2. re-boot into chosen pve kernel.
3. Update OMV7 in the normal way via WebUI Update Management.
4. Via the WebUI System omv-extras enable backports.
Your post-upgrade fix fails as there is no pve repo post update. The OMV6/7 upgrade deletes the pve repo and AFAIK the only thing that installs a pve repo on OMV is when omv-installproxmox is run.
I installed the 6.5 kernel before doing that. I guess that step was assumed no matter what the solution. I guess I could make omv-release-upgrade stop deleting it but my energy to test it is very low.
4. Via the WebUI System omv-extras enable backports.
If the packages are newer in the Debian backports repo, this could still lead to the zfs packages being updated and dkms/zfs-dkms being installed. I could have something (zfs plugin or kernel plugin) create an apt preferences file but it would be very confusing due to the number of options possible. I think the safest thing to do is leave backports disabled. I don't think it is needed for anything on OMV 7.x currently anyway.
AFAIU, the default in OMV7 is OMV_APT_USE_KERNEL_BACKPORTS=YES. Happy to leave if off
That is correct. It just isn't a good idea when backports packages are newer than proxmox.
Took the plunge on upgrading my live server, after clonezilla-ing it.
1. Ran sudo omv-upgrade ok.
2. Ran sudo omv-release-upgrade which returned an error again:
/tmp/apt-dpkg-install-YdKkJs/012-firmware-ath9k-htc_1.4.0-108-gd856466+dfsg1-1.3+deb12u1_all.deb
E: Sub-process /usr/bin/dpkg returned an error code (1)3. Ran sudo apt --fix-broken install, and took the options to install the maintainer's version of config files. Update-initramfs errored with "Operation was interrupted before it could finish".
4. Ran fix6to7upgrade with no errors.
5. Rebooted ok. Shares available, web gui available etc. All seems ok at first glance.
The only thing out of whack is that zfs -V returns:
zfs-2.2.3-pve1
zfs-kmod-2.1.9-pve1
And uname -r returns:
6.1.15-1-pve
EDIT: Upgraded to Proxmox 6.5 via web gui and zfs -V now shows zfs-2.2.3-pve1 & zfs-kmod-2.2.3-pve1
Don’t have an account yet? Register yourself now and be a part of our community!