OneDrive looping with error

Quote from graealex

Since not too long, OneDrive plugin keeps looping after start and fails with the following error:

Code

May 07 23:26:46 xxx onedrive[691796]: Reading configuration file: /var/cache/onedrive/config
May 07 23:26:46 xxx onedrive[691796]: Invalid value for key in config file: verbose
May 07 23:26:46 xxx onedrive[691796]: Configuration file has errors - please check your configuration

The content of the file /var/cache/onedrive/config:

Code

# This file is auto-generated by openmediavault (https://www.openmediavault.org)
# WARNING: Do not edit this file, your changes will get lost.
enable_logging = "true"
verbose = "true"
sync_dir = "/srv/dev-disk-by-uuid-4faa5941-08a5-4ef9-8e4d-f796723d162e/onedrive/"
sync_dir_permissions = "750"
sync_file_permissions = "640"
local_first = "false"
no_remote_delete = "false"
cleanup_local_files = "false"
download_only = "false"
upload_only = "false"
skip_dotfiles = "false"
monitor_interval = "43200"
monitor_fullscan_frequency = "12"
rate_limit = "0"
# Fix issues related to curl that is installed by Debian.
# https://github.com/abraunegg/onedrive/blob/master/docs/usage.md#compatibility-with-curl
force_http_11 = "true"
ip_protocol_version = "1"
# Do not display the warning message on startup.
disable_notifications = "true"

Display More

openmediavault 7.7.6-1

openmediavault-onedrive 7.1.4-3

onedrive Version: 2.5.5-1+np1+1.1

I assume I am not to mess with /var/cache/onedrive/config as indicated by the header. I changed it anyway and put a # in front of verbose = "true", understanding that it'll get overwritten eventually.

After having to do omv-onedrive --reauth since the service has been inoperable for too long, a sync was successfully started.

Display More

According to https://github.com/openmediava…edrive/files/config.j2#L2 this config option is default to 0. If onedrive complains true is invalid, this means you've set the OMV_ONEDRIVE_VERBOSE environment variable manually to true. If you want to enable verbose, then you need to set it to a number, e.g. 1. See code in onedrive here and here.

Quote from abraunegg

Or just read the documentation .. thats why it exists .. no need to delve into reading code!!!

That's incorrect in this case. The verbose option is in the Command Line Interface (CLI) Only Options section. There is no explanation how to configure it correctly via config file.

And to be honest I don't care because this is a user error and not a bug in my code. I just wanted to show the user where the problem lies.

Quote from abraunegg

Setting 'verbose' via config file, whilst it may work is not a supported option or method. Please set the option in the correct manner.

It is also feasible and easier for me to implement in the plugin.

I've refactored the verbose thingy and commited https://github.com/openmediava…b2273ba8eca0b109349b67987. With the OMV_ONEDRIVE_SYSTEMD_EXECSTART_ARGS env var it is much easier now for users to customize addtional command line args.

Quote from graealex

Also this!?

Code

root@graealexhd1:~# sudo omv-env list | grep OMV_ONEDRIVE_VERBOSE
OMV_ONEDRIVE_VERBOSE
root@graealexhd1:~# sudo omv-env unset OMV_ONEDRIVE_VERBOSE
root@graealexhd1:~# sudo omv-env list | grep OMV_ONEDRIVE_VERBOSE
OMV_ONEDRIVE_VERBOSE

Am I too stupid to unset an environment variable?

The list command lists all existing environment variables.

Quote from graealex

If setting an environment variable leads to the plugin generating an invalid config file, it is a bug in the plugin code.

No, you are using an undocumented feature, so YOU NEED to know what you are doing and what YOU are injecting into the configuration.

you need to read the documentation carefully how to use the omv-env command.

Quote from graealex

This does not cause an error with onedrive, though. Why is it now "0" instead of "false" (where it had been "true" before)?

Because this option needs to be a number.

In the latest plugin version you need to use OMV_ONEDRIVE_SYSTEMD_EXECSTART_ARGS and set it to --verbose.