Minor Bug SFTP - Duplicated Entries

  • Hi,

    I'm describing a small bug I encountered after the latest SFTP Plugin update.

    In the Service >> Sftp >> Shares section, when creating a share, you're prompted to specify the User and Shared Folder.

    However, if you subsequently create a new entry with the same user and the same shared folder (by mistake or forgetfulness), a duplicate is created, resulting in duplicate entries not only in the plugin but also in fstab (see attached screenshots). I don't know what undesirable effects this might cause in the future, but each User-Folder pair entry should be logically unique. If I remember correctly, this didn't happen in the previous version of the Plugin (but I could be misremembering), and an error was reported when saving.

    This error reporting is now correct in the SMB and FTP services, preventing duplicate entries with unpredictable effects.

    Thank you.

    • Official Post

    If I remember correctly, this didn't happen in the previous version of the Plugin (but I could be misremembering)

    I didn't change anything with share creation. So, this has always been there.


    And let me save you some time by saying you don't need to post screenshots.

    This error reporting is now correct in the SMB and FTP services, preventing duplicate entries with unpredictable effects.

    Not sure what this means. Is it related to the sftp plugin?

    omv 8.5.8-1 synchrony | 7.0 proxmox kernel

    plugins:

    omvextrasorg 8.0.3 | kvm 8.3.2 | compose 8.1.24 | cterm 8.0.3 | borgbackup 8.2.1 | tempmon 8.0.5 |

    mergerfs 8.0.2 | scripts 8.0.6 | writecache 8.2.4 | backup 8.1 | kernel 8.0.16


    omv-extras.org plugins source code and issue tracker - github - changelogs


    Please try ctrl-shift-R and read this before posting a question.

    Please put your OMV system details in your signature.
    Please don't PM for support... Too many PMs!

    • Official Post

    Fixed in 8.0.3 in the repo now.

    omv 8.5.8-1 synchrony | 7.0 proxmox kernel

    plugins:

    omvextrasorg 8.0.3 | kvm 8.3.2 | compose 8.1.24 | cterm 8.0.3 | borgbackup 8.2.1 | tempmon 8.0.5 |

    mergerfs 8.0.2 | scripts 8.0.6 | writecache 8.2.4 | backup 8.1 | kernel 8.0.16


    omv-extras.org plugins source code and issue tracker - github - changelogs


    Please try ctrl-shift-R and read this before posting a question.

    Please put your OMV system details in your signature.
    Please don't PM for support... Too many PMs!

  • Not sure what this means. Is it related to the sftp plugin?

    I meant to say that SMB and FTP services don't create duplicate entries because the system correctly warns you with an error message if a duplicate entry is created and prevents it from being saved. I was just clarifying that the duplicate entries issue only occurred with the SFTP plugin.

    Thanks for the solution.

    • Official Post

    I meant to say that SMB and FTP services don't create duplicate entries because the system correctly warns you with an error message if a duplicate entry is created and prevents it from being saved.

    They have it easier since they just have to maintain a unique name. Many other plugins are doing this too. sftp shares have to maintain uniqueness over two settings.

    I was just clarifying that the duplicate entries issue only occurred with the SFTP plugin.

    What you reported was very clear without the smb and ftp comment.

    omv 8.5.8-1 synchrony | 7.0 proxmox kernel

    plugins:

    omvextrasorg 8.0.3 | kvm 8.3.2 | compose 8.1.24 | cterm 8.0.3 | borgbackup 8.2.1 | tempmon 8.0.5 |

    mergerfs 8.0.2 | scripts 8.0.6 | writecache 8.2.4 | backup 8.1 | kernel 8.0.16


    omv-extras.org plugins source code and issue tracker - github - changelogs


    Please try ctrl-shift-R and read this before posting a question.

    Please put your OMV system details in your signature.
    Please don't PM for support... Too many PMs!

Participate now!

Don’t have an account yet? Register yourself now and be a part of our community!