OMVEXTRAS - OpenVPN - change wish

Hello, community!

I want to use OMVExtras OpenVPN, but I need to use UDP + bridge mode + TAP adapter (all clients are Windows machines, no Android). All I want is L2 networking over VPN. When I try to modify server.conf, it change back to TUN every time I commit any change over configuration webpage. Can anyone help what can I edit so my change to TAP persist - or better, is there any possibility that we can get this setting available and working over web config?

Thank you!

Best regards, Jan

I will try to answer myself It's nearly impossible to fullfill my wish without tweaking plugin itself :). I found where I can change all settings, but after every plugin upgrade it reverts to "default state". I am asking thich changes because sometimes we need to connect two or more clients together without need to access internal network of OMV. So I would like to to ask "ryecoaaron" kindly (I think he's the one who can help), if there's possibility to modify OMVExtras-OpenVPN plugin like this:

- add selection for TUN / TAP device

config for TUN:

dev tun
persist-tun

config for TAP ("persist-tun" shouldn't be in config)

dev tap

- split "Default gateway" setting to "Default gateway" and "Static route" (static route is doing troubles - someone mentioned it on "github issues" also). I'm almost 99% sure, that you do not need to add line push "route $vpn_network $vpn_mask" also (I never used this).

- add option to use "Duplicate CN" - so user can connect several times using only 1 certificate. Disvantage is, your IP address will not persist on every reconnect. ("duplicate-cn" and "ifconfig-pool-persist" cannot be used together)

config for "Duplicate CN" enabled

duplicate-cn

config for "Duplicate CN" disabled

ifconfig-pool-persist ipp.txt

- everything else we can do using "Extra options" field I think (per user folders with push directives, etc).

Thank you for your effort!

Best regards, Jan

I am a little bit "n00b" using github I can try rework script and post it here maybe, but never did anything like this on github :-/

Changed everything I found - attached. If its possible to prepare "testing" version and help me how to install it, I can do tests as well for you!

Thanks!!

edit: not translated to all languages :-/

found 1 problem maybe - file "\usr\sbin\omv-openvpn"

    if [ $device -eq "TUN" ]; then

should be probably (lower-case)

    if [ $device -eq "tun" ]; then

Ok, I will look into "migrations.d" update files. As i can see, there is a check if "new" variable exists or not. If not, create with default value - am I right?

Here we go (added 3 variables):

#!/bin/sh
#
# @license   http://www.gnu.org/licenses/gpl.html GPL Version 3
# @author    Volker Theile <volker.theile@openmediavault.org>
# @author    OpenMediaVault Plugin Developers <plugins@omv-extras.org>
# @copyright Copyright (c) 2009-2013 Volker Theile
# @copyright Copyright (c) 2013-2020 OpenMediaVault Plugin Developers
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.

set -e

. /usr/share/openmediavault/scripts/helper-functions

SERVICE_XPATH_NAME="openvpn"
SERVICE_XPATH="/config/services/${SERVICE_XPATH_NAME}"

if ! omv_config_exists "${SERVICE_XPATH}/device"; then
    omv_config_add_key "${SERVICE_XPATH}" "device" "tun"
fi

if ! omv_config_exists "${SERVICE_XPATH}/duplicate_cn"; then
    omv_config_add_key "${SERVICE_XPATH}" "duplicate_cn" "0"
fi

if ! omv_config_exists "${SERVICE_XPATH}/default_route"; then
    omv_config_add_key "${SERVICE_XPATH}" "default_route" "1"
fi

exit 0

Error #0:
RuntimeException: Failed to index key 'device' of 'device.0' because it has no children. in /usr/share/php/openmediavault/dictionary.inc:145
Stack trace:
#0 /usr/share/php/openmediavault/config/configobject.inc(194): OMV\Dictionary->set('device.0', 'tun')
#1 /usr/share/php/openmediavault/config/configobject.inc(272): OMV\Config\ConfigObject->set('device.0', 'tun', false)
#2 /usr/share/php/openmediavault/config/configobject.inc(234): OMV\Config\ConfigObject->setFlatAssoc(Array, false, false)
#3 /usr/share/php/openmediavault/config/database.inc(99): OMV\Config\ConfigObject->setAssoc(Array, false)
#4 /usr/share/openmediavault/engined/module/openvpn.inc(68): OMV\Config\Database->get('conf.service.op...')
#5 /usr/share/openmediavault/engined/rpc/services.inc(60): OMV\Engined\Module\OpenVpn->getStatus()
#6 [internal function]: Engined\Rpc\Services->getStatus(Array, Array)
#7 /usr/share/php/openmediavault/rpc/serviceabstract.inc(123): call_user_func_array(Array, Array)
#8 /usr/share/php/openmediavault/rpc/rpc.inc(86): OMV\Rpc\ServiceAbstract->callMethod('getStatus', Array, Array)
#9 /usr/sbin/omv-engined(537): OMV\Rpc\Rpc::call('Services', 'getStatus', Array, Array, 1)
#10 {main}

how about change everything to "device_type" or maybe better "device_ovpn"

NO error on install ! Will check later all settings are written to cfg files correctly Thanks