OMVEXTRAS - OpenVPN - change wish

1) Its working! Changes are saving properly to both configs - server and client.

2) I found a glitch - but it's not releated to this update (happened to me before also). Sometimes it happens, that service is not started/restarted properly after SAVE/APPLY. So it's still running with old config loaded - checked through PID (or not started at all). When I do /etc/init.d/openvpn restart manually (logged on as root), it restarts just fine.

3) new MAJOR version 2.5.0 of OpenVPN released (28.10.2020) https://openvpn.net/community-downloads/ . What version are you using on server? If "you" upgrade to 2.5.0, we can use stronger and recommended cipher (I can do some non-dynamic changes in server/client config files if you send me latest source files)

4) have some warnings on client side (I'm using version 2.5.0) so I can tweak configs little (static settings again)...but it's just warnings

Are you still interested to these changes? Probably last changes and it can go "to production". (after testing OFC)

Zitat

The plugin installs the openvpn package from the debian repos (2.4.7 right now). I really don't want to maintain a new package in the omv-extras repo.

Thats fine, didnt know this I

Zitat

If you want to change the code to do different things when it finds 2.5.0 installed....

Okay, plugin is working right now even with 2.5.0 client, so lets wait for 2.5.0 and then I will do minor config changes and kindly ask you again (if you don't mind).

Zitat

The restart should probably added to the /usr/sbin/omv-openvpn script

Don't know how this is working in OMV. In GUI I have to Disable plugin, Save, Apply, Enable plugin, Save, Apply. So we need to do /etc/init.d/openvpn restart only when plugin enabled. When disabled we don't need to do anything. Can you look at this in /usr/sbin/omv-openvpn script, please? I can test it again and if this works, we have done our job for now .

Everything else is fine - I tested writing configs with different settings, connected with my client... All OK

Thank you!

Yes, OMV5 has working plugin.

install omvextrasorg plugin and then:

we are going little bit offtopic here

Zitat von ryecoaaron

For now. Once jimmy_cr's changes are complete, the plugin will be in the regular repo.

Zitat

There is no need to enable either of those repos since there is nothing in them.

Was not sure so I screenshotted my setup .

Zitat

For now. Once jimmy_cr's changes are complete, the plugin will be in the regular repo.

I think, that we are done for OpenVPN version 2.4.7... Just don't know how to force restart on Save/Apply when plugin enabled.

Probably we need to modify /usr/sbin/omv-openvpn script - function setup_config()

We should add something to the very end of this function... something like

setup_config()
{
...
...
...
...

local ovpnenabled=$(omv_config_get "$SERVICE_XPATH/enabled")
if (ovpnenabled)
    {
        /etc/init.d/openvpn restart
    } 
}

but I don't know what variable to query to check if plugin enabled... i just put as an example local ovpnenabled=$(omv_config_get "$SERVICE_XPATH/enabled")

Yeah - on Save/Apply:

Error #0:
OMV\ExecException: Failed to execute command 'export PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin; export LANG=C.UTF-8; omv-salt deploy run --no-color openvpn 2>&1' with exit code '1': omv.jimmy.chrudim.cz:
----------
          ID: update_openmediavault_openvpn_config
    Function: cmd.run
        Name: /usr/sbin/omv-openvpn setup
      Result: True
     Comment: Command "/usr/sbin/omv-openvpn setup" run
     Started: 07:30:54.686273
    Duration: 1138.347 ms
     Changes:
              ----------
              pid:
                  15397
              retcode:
                  0
              stderr:
              stdout:
----------
          ID: start_openvpn_service
    Function: service.running
        Name: openvpn
      Result: False
     Comment: The following requisites were not found:
                                 watch:
                                     file: /etc/openvpn/server.conf
     Started: 07:30:55.939583
    Duration: 0.017 ms
     Changes:

Summary for omv.jimmy.chrudim.cz
------------
Succeeded: 1 (changed=1)
Failed:    1
------------
Total states run:     2
Total run time:   1.138 s in /usr/share/php/openmediavault/system/process.inc:182
Stack trace:
#0 /usr/share/php/openmediavault/engine/module/serviceabstract.inc(62): OMV\System\Process->execute()
#1 /usr/share/openmediavault/engined/rpc/config.inc(167): OMV\Engine\Module\ServiceAbstract->deploy()
#2 [internal function]: Engined\Rpc\Config->applyChanges(Array, Array)
#3 /usr/share/php/openmediavault/rpc/serviceabstract.inc(123): call_user_func_array(Array, Array)
#4 /usr/share/php/openmediavault/rpc/serviceabstract.inc(149): OMV\Rpc\ServiceAbstract->callMethod('applyChanges', Array, Array)
#5 /usr/share/php/openmediavault/rpc/serviceabstract.inc(588): OMV\Rpc\ServiceAbstract->OMV\Rpc\{closure}('/tmp/bgstatusgX...', '/tmp/bgoutputGU...')
#6 /usr/share/php/openmediavault/rpc/serviceabstract.inc(159): OMV\Rpc\ServiceAbstract->execBgProc(Object(Closure))
#7 /usr/share/openmediavault/engined/rpc/config.inc(189): OMV\Rpc\ServiceAbstract->callMethodBg('applyChanges', Array, Array)
#8 [internal function]: Engined\Rpc\Config->applyChangesBg(Array, Array)
#9 /usr/share/php/openmediavault/rpc/serviceabstract.inc(123): call_user_func_array(Array, Array)
#10 /usr/share/php/openmediavault/rpc/rpc.inc(86): OMV\Rpc\ServiceAbstract->callMethod('applyChangesBg', Array, Array)
#11 /usr/sbin/omv-engined(537): OMV\Rpc\Rpc::call('Config', 'applyChangesBg', Array, Array, 1)
#12 {main}