Btrfs Scrub script applied on device partitions instead of mountpoints

oopenmediavault · 19. April 2023

Hello,

I took a look at https://github.com/openmediava…/usr/sbin/omv-btrfs-scrub, which is used to periodically scrub the disks with btrfs filesystem attached to the openmediavault server.

I noticed, that the script finds the partitions on which a btrfs filesystem is installed. Now this approach works, but not perfectly.

People with a btrfs raid 1 will have only one of the disks scrubbed ( the one with the mountpoint)

For example, the output of lsblk is following, it will only scrub /dev/sde1.

Code: Output of lsblk

sdc                  8:32   0  10.9T  0 disk
└─sdc1               8:33   0  10.9T  0 part
sde                  8:64   0  10.9T  0 disk 
└─sde1               8:65   0  10.9T  0 part /srv/dev-disk-by....

To fix this, the script should be changed to one that btrfs scrubs with the mountpoints, instead of the partitions. which works exactly the same, but will scrub both disks (or all disks, that are used in a btrfs raid). votdev

oopenmediavault · 21. April 2023

Is this something that you disagree with? Not sure if you saw the post or not. I'm just trying to help, so I hope youre not annoyed if I bring up btrfs up a lot lately

votdev · 21. April 2023

WarpMachine · 23. Mai 2023

Zitat von votdev

https://github.com/openmediava…4b4f6d453c3e98b93aaf147aa
https://github.com/openmediava…2ced30f3af8920d1f6d3b2400

Hi,

I noticed that with this recent change, the scrub is also running over the mount point generated by the SFTP plugin (shares) in the same disk. For example:

Code

findmnt --types btrfs
TARGET                                                     SOURCE            FSTYPE OPTIONS
/sftp/john/DriveD                                       /dev/sda[/DriveD] btrfs  rw,relatime,space_cache,subvolid=258,subvol=/DriveD
/srv/dev-disk-by-uuid-6ede0c96-dfb6-4342-82f2-44d49aff51aa /dev/sda          btrfs  rw,relatime,space_cache,subvolid=5,subvol=/
/sftp/john/DriveG                                       /dev/sda[/DriveG] btrfs  rw,relatime,space_cache,subvolid=4011,subvol=/DriveG

The scrubs will run over the sftp folders in the same disk:

Code

Scrubbing the file system mounted at /sftp/john/DriveD [UUID=6ede0c96-dfb6-4342-82f2-44d49aff51aa] ...
Scrubbing the file system mounted at /sftp/john/DriveG [UUID=6ede0c96-dfb6-4342-82f2-44d49aff51aa] ...
Scrubbing the file system mounted at /srv/dev-disk-by-uuid-6ede0c96-dfb6-4342-82f2-44d49aff51aa [UUID=6ede0c96-dfb6-4342-82f2-44d49aff51aa] ...

Notice that DriveD and DriveG are directories within the /srv/dev-disk-uudi-[..] generated by OMV. The "/sfto/john/..." generated by the SFTP plugin via the share configuration/page.

The previous version worked fine, scrubbing just the "/srv/dev-disk-by-uuid-6ede0c96-dfb6-4342-82f2-44d49aff51aa"

Thank you,

Warp

votdev · 23. Mai 2023

Duplicates will be filtered in openmediavault 6.4.0, see https://github.com/openmediava…a34e63b46b2e17f471d6f2616 and following commits.

Btrfs Scrub script applied on device partitions instead of mountpoints

votdev 21. April 2023

votdev 21. April 2023

Jetzt mitmachen!

Tags