SnapRAID 7.0.7 - Wiping Drive Config on Upgrade

asandhu · 12. April 2024

Just upgraded to plugin 7.0.7 and the SnapRAID -> Arrays, Drives, and Rules pages all return a 500 - Invalid RPC Response error on load.

I did notice an error while it was upgrading, from what I can remember it read something along the lines of ""paritynum" is not an object".

I did have the issue when upgrading from OMV 6->7 with the incorrect parity number but I fixed that manually a while ago, not sure if that could be causing this?

Syslog error:

Code

2024-04-12T15:53:43.648978-06:00 nas omv-engined[2629466]: PHP Fatal error: Uncaught TypeError: OMV\Config\ConfigObject::setAssoc(): Argument #1 ($data) must be of type array, string given, called in /usr/share/php/openmediavault/config/database.inc on line 98 and defined in /usr/share/php/openmediavault/config/configobject.inc:248
2024-04-12T15:53:43.649362-06:00 nas omv-engined[2629466]: Stack trace:
2024-04-12T15:53:43.649466-06:00 nas omv-engined[2629466]: #0 /usr/share/php/openmediavault/config/database.inc(98): OMV\Config\ConfigObject->setAssoc()
2024-04-12T15:53:43.649540-06:00 nas omv-engined[2629466]: #1 /usr/share/openmediavault/engined/rpc/snapraid.inc(218): OMV\Config\Database->get()
2024-04-12T15:53:43.649606-06:00 nas omv-engined[2629466]: #2 [internal function]: OMVRpcServiceSnapRaid->getDriveList()
2024-04-12T15:53:43.649670-06:00 nas omv-engined[2629466]: #3 /usr/share/php/openmediavault/rpc/serviceabstract.inc(122): call_user_func_array()
2024-04-12T15:53:43.649741-06:00 nas omv-engined[2629466]: #4 /usr/share/php/openmediavault/rpc/rpc.inc(86): OMV\Rpc\ServiceAbstract->callMethod()
2024-04-12T15:53:43.649802-06:00 nas omv-engined[2629466]: #5 /usr/sbin/omv-engined(535): OMV\Rpc\Rpc::call()
2024-04-12T15:53:43.649862-06:00 nas omv-engined[2629466]: #6 {main}
2024-04-12T15:53:43.649928-06:00 nas omv-engined[2629466]:   thrown in /usr/share/php/openmediavault/config/configobject.inc on line 248

EDIT: config.xml

Code

<snapraid>
      <blocksize>256</blocksize>
      <hashsize>16</hashsize>
      <autosave>0</autosave>
      <nohidden>0</nohidden>
      <debug>0</debug>
      <sendmail>1</sendmail>
      <runscrub>1</runscrub>
      <scrubfreq>7</scrubfreq>
      <updthreshold>0</updthreshold>
      <delthreshold>0</delthreshold>
      <percentscrub>12</percentscrub>
      <scrubpercent>100</scrubpercent>
      <drives>
        <drive>paritynum</drive>
        <drive>paritynum</drive>
        <drive>
          <uuid>f2a3aab3-10dc-4ce0-8e57-14c3d7e2edf6</uuid>
          <arrayref>114a88d2-53ed-11ed-8eee-b3f2573b9c38</arrayref>
          <mntentref>42f0f779-026c-41d4-b366-ec8af06554fa</mntentref>
          <name>parity1</name>
          <label/>
          <path>/srv/dev-disk-by-uuid-b4087104-2bef-4eb3-89db-3289206a9f0d</path>
          <content>0</content>
          <data>0</data>
          <parity>1</parity>
          <paritynum>1</paritynum>
          <paritysplit>0</paritysplit>
        </drive>
      </drives>
      <rules/>
      <arrays>
        <array>
          <uuid>114a88d2-53ed-11ed-8eee-b3f2573b9c38</uuid>
          <name>array1</name>
        </array>
      </arrays>
    </snapraid>

Alles anzeigen

I suspect the issue is from the <drive>paritynum</drive> lines...where I expect is where my data drives should be? This was all working fine pre-upgrade.

EDIT 2: What config.xml looked like prior to upgrade (taken from fsa backup performed last night):

Code

<snapraid>
      <blocksize>256</blocksize>
      <hashsize>16</hashsize>
      <autosave>0</autosave>
      <nohidden>0</nohidden>
      <debug>0</debug>
      <sendmail>1</sendmail>
      <runscrub>1</runscrub>
      <scrubfreq>7</scrubfreq>
      <updthreshold>0</updthreshold>
      <delthreshold>0</delthreshold>
      <percentscrub>12</percentscrub>
      <scrubpercent>100</scrubpercent>
      <drives>
        <drive>
          <uuid>dbe482a4-9d7c-493c-81a1-8628cbe7c2fc</uuid>
          <mntentref>23cd7b45-4005-4be5-8471-8f5781b149c0</mntentref>
          <name>media1</name>
          <label></label>
          <path>/srv/dev-disk-by-uuid-7971638c-fbc6-4ac2-8ed6-85159355b2e2</path>
          <content>1</content>
          <data>1</data>
          <parity>0</parity>
          <arrayref>114a88d2-53ed-11ed-8eee-b3f2573b9c38</arrayref>
          <paritynum>1</paritynum>
          <paritysplit>0</paritysplit>
        </drive>
        <drive>
          <uuid>568bfbd1-23de-4e69-88b9-c88145663922</uuid>
          <mntentref>9a3fc399-d220-4a94-9aad-447cbd37cf29</mntentref>
          <name>media2</name>
          <label></label>
          <path>/srv/dev-disk-by-uuid-8a296679-fd37-42d8-9cad-f49db16288a6</path>
          <content>1</content>
          <data>1</data>
          <parity>0</parity>
          <arrayref>114a88d2-53ed-11ed-8eee-b3f2573b9c38</arrayref>
          <paritynum>1</paritynum>
          <paritysplit>0</paritysplit>
        </drive>
        <drive>
          <uuid>f2a3aab3-10dc-4ce0-8e57-14c3d7e2edf6</uuid>
          <arrayref>114a88d2-53ed-11ed-8eee-b3f2573b9c38</arrayref>
          <mntentref>42f0f779-026c-41d4-b366-ec8af06554fa</mntentref>
          <name>parity1</name>
          <label></label>
          <path>/srv/dev-disk-by-uuid-b4087104-2bef-4eb3-89db-3289206a9f0d</path>
          <content>0</content>
          <data>0</data>
          <parity>1</parity>
          <paritynum>1</paritynum>
          <paritysplit>0</paritysplit>
        </drive>
      </drives>
      <rules></rules>
      <arrays>
        <array>
          <uuid>114a88d2-53ed-11ed-8eee-b3f2573b9c38</uuid>
          <name>array1</name>
        </array>
      </arrays>
    </snapraid>

Alles anzeigen

I'm assuming restoring those drive configs would fix the issue but want to make the maintainer aware this is happening, without a backup I suspect those drive configs may be lost for others who upgrade and have this issue?

ryanupp · 13. April 2024

+1 for this issue after upgrading, and also to confirm that restoring the drive configs from a config backup resolved the error for me.

orb71 · 13. April 2024

I witnessed the same issue. Here is the output from omv-upgrade.

Code

The following packages will be upgraded:
  openmediavault-snapraid
1 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
Need to get 0 B/38.8 kB of archives.
After this operation, 2048 B of additional disk space will be used.
apt-listchanges: Reading changelogs...
apt-listchanges: Changelogs
---------------------------

openmediavault-snapraid (7.0.7) stable; urgency=low

  * Fix parity number issues on upgrades

 -- OpenMediaVault Plugin Developers <plugins@omv-extras.org>  Fri, 12 Apr 2024 12:50:33 -0500

apt-listchanges: Mailing root: apt-listchanges: changelogs for nas
(Reading database ... 41046 files and directories currently installed.)
Preparing to unpack .../openmediavault-snapraid_7.0.7_all.deb ...
Unpacking openmediavault-snapraid (7.0.7) over (7.0.6) ...
Setting up openmediavault-snapraid (7.0.7) ...
Updating configuration database ...
  Running migration conf.service.snapraid_7.0.7
[ERROR   ] Rendering exception occurred
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/salt/utils/templates.py", line 477, in render_jinja_tmpl
    output = template.render(**decoded_context)

             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

[snap]

openmediavault.json.schema.SchemaValidationException: drives.drive[1]: The value 'paritynum' is not an object.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/salt/utils/templates.py", line 219, in render_tmpl
    output = render_str(tmplstr, context, tmplpath)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/salt/utils/templates.py", line 523, in render_jinja_tmpl
    raise SaltRenderError(
salt.exceptions.SaltRenderError: Jinja error: drives.drive[1]: The value 'paritynum' is not an object.
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/salt/utils/templates.py", line 477, in render_jinja_tmpl
    output = template.render(**decoded_context)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/jinja2/environment.py", line 1301, in render
    self.environment.handle_exception()
  File "/usr/lib/python3/dist-packages/jinja2/environment.py", line 936, in handle_exception
    raise rewrite_traceback_stack(source=source)
  File "<template>", line 18, in top-level template code
  File "/usr/lib/python3/dist-packages/jinja2/sandbox.py", line 396, in call
    return __context.call(__obj, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 149, in __call__
    return self.loader.run(run_func, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1234, in run
    return self._last_context.run(self._run_as, _func_or_method, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1249, in _run_as
    return _func_or_method(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/var/cache/salt/minion/extmods/modules/omv_conf.py", line 41, in get
    objs = db.get(id_, identifier)
           ^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/openmediavault/config/database.py", line 85, in get
    query.execute()
  File "/usr/lib/python3/dist-packages/openmediavault/config/database.py", line 735, in execute
    self._response = self._elements_to_object(elements)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/openmediavault/config/database.py", line 493, in _elements_to_object
    result.validate()
  File "/usr/lib/python3/dist-packages/openmediavault/config/object.py", line 236, in validate
    self.model.validate(self.get_dict())
  File "/usr/lib/python3/dist-packages/openmediavault/config/datamodel.py", line 202, in validate
    self.schema.validate(data)
  File "/usr/lib/python3/dist-packages/openmediavault/json/schema.py", line 175, in validate
    self._validate_type(value, schema, name)
  File "/usr/lib/python3/dist-packages/openmediavault/json/schema.py", line 230, in _validate_type
    raise last_exception
  File "/usr/lib/python3/dist-packages/openmediavault/json/schema.py", line 201, in _validate_type
    self._validate_object(value, schema, name)
  File "/usr/lib/python3/dist-packages/openmediavault/json/schema.py", line 306, in _validate_object
    self._check_properties(value, schema, name)
  File "/usr/lib/python3/dist-packages/openmediavault/json/schema.py", line 521, in _check_properties
    self._validate_type(value[propk], propv, path)
  File "/usr/lib/python3/dist-packages/openmediavault/json/schema.py", line 230, in _validate_type
    raise last_exception
  File "/usr/lib/python3/dist-packages/openmediavault/json/schema.py", line 201, in _validate_type
    self._validate_object(value, schema, name)
  File "/usr/lib/python3/dist-packages/openmediavault/json/schema.py", line 306, in _validate_object
    self._check_properties(value, schema, name)
  File "/usr/lib/python3/dist-packages/openmediavault/json/schema.py", line 521, in _check_properties
    self._validate_type(value[propk], propv, path)
  File "/usr/lib/python3/dist-packages/openmediavault/json/schema.py", line 230, in _validate_type
    raise last_exception
  File "/usr/lib/python3/dist-packages/openmediavault/json/schema.py", line 195, in _validate_type
    self._validate_array(value, schema, name)
  File "/usr/lib/python3/dist-packages/openmediavault/json/schema.py", line 297, in _validate_array
    self._check_items(value, schema, name)
  File "/usr/lib/python3/dist-packages/openmediavault/json/schema.py", line 549, in _check_items
    self._validate_type(itemv, schema['items'], path)
  File "/usr/lib/python3/dist-packages/openmediavault/json/schema.py", line 230, in _validate_type
    raise last_exception
  File "/usr/lib/python3/dist-packages/openmediavault/json/schema.py", line 201, in _validate_type
    self._validate_object(value, schema, name)
  File "/usr/lib/python3/dist-packages/openmediavault/json/schema.py", line 301, in _validate_object
    raise SchemaValidationException(
openmediavault.json.schema.SchemaValidationException: drives.drive[1]: The value 'paritynum' is not an object.

; line 18

---
[...]
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.

{% set config = salt['omv_conf.get']('conf.service.snapraid') %}    <======================
{% set confDir = '/etc/snapraid' %}
{% set confPrefix = 'omv-snapraid-' %}

configure_snapraid_envvar_dir:
  file.directory:
[...]
---
[CRITICAL] Rendering SLS 'base:omv.deploy.snapraid.default' failed: Jinja error: drives.drive[1]: The value 'paritynum' is not an object.
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/salt/utils/templates.py", line 477, in render_jinja_tmpl
    output = template.render(**decoded_context)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 [snap]
openmediavault.json.schema.SchemaValidationException: drives.drive[1]: The value 'paritynum' is not an object.

; line 18

---
[...]
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.

{% set config = salt['omv_conf.get']('conf.service.snapraid') %}    <======================
{% set confDir = '/etc/snapraid' %}
{% set confPrefix = 'omv-snapraid-' %}

configure_snapraid_envvar_dir:
  file.directory:
[...]
---
Processing triggers for rsyslog (8.2302.0-1) ...
Processing triggers for openmediavault (7.0.5-1) ...
Updating workbench configuration files ...
Restarting engine daemon ...

Alles anzeigen

orb71 · 13. April 2024

It appears that the work performed here has caused an issue with the single parity configuration during parameter validation.

I've discovered a workaround to resolve this:

Create a new 'raid'.
On each disk, set parity to 2, even if initially configured as data/content. It is safe since it is ignored
Save your changes.
Then, revert the setting on the parity disk (only) to 1
Save your changes again.

Snapraid should be functional again

I didn't try on an existing 'raid', let us know if it works for you

ryecoaaron · 13. April 2024

Sorry about the bug. It is fixed now and 7.0.8 is in the repo.

fix typo · OpenMediaVault-Plugin-Developers/openmediavault-snapraid@af2891c

Signed-off-by: Aaron Murray <plugins@omv-extras.org>

github.com

k4ZzTBG7Gk · 13. April 2024

Hmmm, if we don't have a backup of the old config, what is there to be done?

I upgraded to v0.8

Thanks

ryecoaaron · 13. April 2024

Zitat von k4ZzTBG7Gk

what is there to be done?

If you don't remember how it is setup, save off the config file /etc/snapraid/ and uninstall the plugin. Then reinstall the plugin and recreate the array.

chente · 13. April 2024

Zitat von k4ZzTBG7Gk

Hmmm, if we don't have a backup of the old config, what is there to be done?
I upgraded to v0.8

In your case you have the previous database configuration. So, you can do the following:

- Backup of the current database. File /etc/openmediavault/config.xml

- Replace the Snapraid part with what you had before, what you published in post No. 1

- Run omv-salt deploy run snapraid

If ryecoaaron has not changed the database format in version 7.08 the plugin should work. If you do not have a system backup, it is better to wait for ryecoaaron to confirm this procedure.

ryecoaaron · 13. April 2024

Zitat von chente

If ryecoaaron has not changed the database format in version 7.08 the plugin should work. I

I did not change the database format. The bug came from trying to fix bad upgrades from OMV 6. I mention how to fix in post #7

ryecoaaron · 13. April 2024

Ah I see the old config. That could be placed back in the omv database like Chente mentioned.

k4ZzTBG7Gk · 13. April 2024

Zitat von chente

In your case you have the previous database configuration. So, you can do the following:
- Backup of the current database. File /etc/openmediavault/config.xml
- Replace the Snapraid part with what you had before, what you published in post No. 1
- Run omv-salt deploy run snapraid
If ryecoaaron has not changed the database format in version 7.08 the plugin should work. If you do not have a system backup, it is better to wait for ryecoaaron to confirm this procedure.

I think you missquote me, since I don't have access to the old config. This would apply for OP.

Now I read the post 7, so will let you know how it goes

PS:

I did have a backup actually of the said config, but I read that it's more or less useless and cannot restore an install, so I went ahead and cloned the usb with rufus. So in the worse case scenario, I will power down and swap omv usbs

chente · 13. April 2024

Zitat von k4ZzTBG7Gk

I think you missquote me, since I don't have access to the old config. This would apply for OP.

You're right, I thought you were asandhu sorry.

chente · 13. April 2024

Zitat von k4ZzTBG7Gk

I did have a backup actually of the said config, but I read that it's more or less useless and cannot restore an install

If you have a backup in which you can access the previous database (file /etc/openmediavault/config.xml) you can also apply that procedure.

ryecoaaron · 13. April 2024

Yep, all you need is the snapraid section of the config file in your backup.

k4ZzTBG7Gk · 13. April 2024

Backup'd the snap configs. Uninstalled the snapraid and reinstalled

Getting an error when trying to recreate the drives (exact as before):

Code

OMV\Json\SchemaValidationException: paritynum: The value "1" is not an integer. in /usr/share/php/openmediavault/json/schema.inc:342
Stack trace:
#0 /usr/share/php/openmediavault/json/schema.inc(293): OMV\Json\Schema->validateInteger()
#1 /usr/share/php/openmediavault/json/schema.inc(631): OMV\Json\Schema->validateType()
#2 /usr/share/php/openmediavault/json/schema.inc(399): OMV\Json\Schema->checkProperties()
#3 /usr/share/php/openmediavault/json/schema.inc(289): OMV\Json\Schema->validateObject()
#4 /usr/share/php/openmediavault/json/schema.inc(261): OMV\Json\Schema->validateType()
#5 /usr/share/php/openmediavault/rpc/paramsvalidator.inc(59): OMV\Json\Schema->validate()
#6 /usr/share/php/openmediavault/rpc/serviceabstract.inc(179): OMV\Rpc\ParamsValidator->validate()
#7 /usr/share/openmediavault/engined/rpc/snapraid.inc(257): OMV\Rpc\ServiceAbstract->validateMethodParams()
#8 [internal function]: OMVRpcServiceSnapRaid->setDrive()
#9 /usr/share/php/openmediavault/rpc/serviceabstract.inc(122): call_user_func_array()
#10 /usr/share/php/openmediavault/rpc/rpc.inc(86): OMV\Rpc\ServiceAbstract->callMethod()
#11 /usr/sbin/omv-engined(535): OMV\Rpc\Rpc::call()
#12 {main}

Alles anzeigen

I think I better swap the omv usb clone installs. It's less than a month old I think. Unless there's other suggestions.

Thanks

k4ZzTBG7Gk · 13. April 2024

Swapped omv usbs. Updated all packages in the old one, snapraid updated to 7.0.8 all working as expected.

Now I will swap back, and replace the config.xml with the working one and

omv-salt deploy run snapraid

Should be good to go, preserving the working usb as a backup as before.

Will post result.

LE: all working great now, no issues.

Thanks for your support and I heart OMV!

ypopovych · 14. April 2024

ryecoaaron I reinstalled the plugin and it's showing error paritynum: The value "1" is not an integer. when I'm trying to add disk to the array

ryecoaaron · 14. April 2024

Zitat von ypopovych

reinstalled the plugin and it's showing error paritynum: The value "1" is not an integer. when I'm trying to add disk to the array

Beitrag

RE: Invalid RPC Response in Snapraid Plugin

[…]

uncheck the data checkbox, change parity num to 2, check data checkbox. I will fix this.

ryecoaaron

14. April 2024

SnapRAID 7.0.7 - Wiping Drive Config on Upgrade

asandhu 13. April 2024

Jetzt mitmachen!