Error if I run my script from "scheduled jobs"

Hi everyone!

I created a script that I will soon post in the guide section as soon as I finished all testing

My latest issue is running it throught scheduled jobs.

If I run it from cli using

/home/Script/test.sh

it works fine.

If I run it from scheduled jobs I recieve this error:

Zitat

Failed to execute command 'export PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin;

export LANG=C.UTF-8; export SHELL=/bin/sh;

sudo --shell --non-interactive --user=root -- /home/Script/Restart_downloader.sh 2>&1' with exit code '2':

/home/Script/Restart_downloader.sh: 7: /home/Script/Restart_downloader.sh: Syntax error: word unexpected (expecting ")")

Error #0:
OMV\ExecException: Failed to execute command 'export PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin; export LANG=C.UTF-8; export SHELL=/bin/sh; sudo --shell --non-interactive --user=root -- /home/Script/Restart_downloader.sh 2>&1' with exit code '2': /home/Script/Restart_downloader.sh: 7: /home/Script/Restart_downloader.sh: Syntax error: word unexpected (expecting ")") in /usr/share/openmediavault/engined/rpc/cron.inc:177
Stack trace:
#0 /usr/share/php/openmediavault/rpc/serviceabstract.inc(588): Engined\Rpc\Cron->Engined\Rpc\{closure}('/tmp/bgstatusEg...', '/tmp/bgoutput34...')
#1 /usr/share/openmediavault/engined/rpc/cron.inc(181): OMV\Rpc\ServiceAbstract->execBgProc(Object(Closure))
#2 [internal function]: Engined\Rpc\Cron->execute(Array, Array)
#3 /usr/share/php/openmediavault/rpc/serviceabstract.inc(123): call_user_func_array(Array, Array)
#4 /usr/share/php/openmediavault/rpc/rpc.inc(86): OMV\Rpc\ServiceAbstract->callMethod('execute', Array, Array)
#5 /usr/sbin/omv-engined(537): OMV\Rpc\Rpc::call('Cron', 'execute', Array, Array, 1)
#6 {main}

Alles anzeigen

This is how I created the job:

I don't get why if I run the script from cli it work while if I run it from cronjob I recieve an error.

OMV\ExecException: Failed to execute command 'export PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin; export LANG=C.UTF-8; export SHELL=/bin/sh; sudo --shell --non-interactive --user=root -- /home/Script/Restart_downloader.sh 2>&1' with exit code '2': /home/Script/Restart_downloader.sh: 7: /home/Script/Restart_downloader.sh: Syntax error: word unexpected (expecting ")") in /usr/share/openmediavault/engined/rpc/cron.inc:177Is this a OMV bug?

Zitat von Adoby

Scripts are run in a shell environment.

It is possible that, unless you specified in the shebang what shell to use, the script is using another shell than the one you are using when you run the script from the cli. I am not sure what script scheduled tasks use by defalut? Possibly the default for the user that the script runs as? I have never tried to use scheduled tasks, so I don't know. I use crontab from the cli.

For example, this shebang as the first line in the script make sure it runs in bash:

#!/usr/bin/env bash

...and this in sh:

#!/usr/bin/env sh

And the syntax can vary a little between different shells. That might be why the script riuns OK from the cli but not as a scheduled job?

In my experience some shells are not correctly setup in OMV. At least that was the case in OMV4. But it seems that bash was correctly setup. Try to set bash as the shell to use both for the user and in the script, unless you have good reasons to use some other shell and verify that it is correctly setup.

Alles anzeigen

#!/usr/bin/env bash

Thanks! That line worked!!

Tonight I'll prepare a post