compose plug-in (7.1) - bug: 2 volumes backup for each config folder

Zitat von bigboo3000

HI

with the last compose plug-in you added this new capability:

- Support backup for paths using environment variables

I saw in the wiki here that we can exclude volumes for backup:

https://wiki.omv-extras.org/do…edule_updates_and_backups

If I respect exemple of the image in the wiki each config folder is backuped twice (one in "0" folder and one in "1" volume).

Maybe you should update the image in the wiki (./config volume should also have # SKIP_BACKUP

Alles anzeigen

mmm... It's strange that it copies twice, I think the problem is the relative paths. I'll have to check that part of the wiki. Thanks for the warning.

Zitat von bigboo3000

It doesn't make much sense to add # SKIP_BACKUP to all volumes lines to all my compose files.

It is not necessary to add # SKIP_BACKUP to all volumes. If you read the documentation you will see that the backup utility discriminates volumes according to several configurable criteria, such as the volume size for example, or the :ro flag.

Zitat von chente

think the problem is the relative paths

You are correct. The plugin backs up the FILENAME.yml and FILENAME.env file and everything in that directory putting them in the "0". If someone is using relative paths, it is possible that it will back it up twice (or more) because a volume is referencing a directory inside the FILENAME.yml directory. It is difficult to deduplicate paths in bash and relative paths are still a pain in the ass. I thought supporting environment variables in the backup would help people stop using relative paths. Evidently I was wrong.

So, the plugin still does not properly support relative paths.

Zitat von bigboo3000

I think that the compose plug-in should only backup the appdata folder by default, and add an option to backup other volumes. It would be the best default setting for the vast majority of users.

Personally, I would rather the backup functionality backup too much than not enough. There are many images that the "appdata" folder is not enough. How would a script determine what the "appdata" folder is?

The backup has functionality to force a backup of a volume or skip it. Reversing the default would cause a lot problems for existing users as well.

After some testing, the plugin is now resolving relative paths and I don't need to do an rsync of the FILENAME.yml directory to the '0' directory. If I just copy the yml and env files instead of doing an rsync, it will stop backing up the relative directories twice. Should be an easy change.

Zitat von ryecoaaron

After some testing, the plugin is now resolving relative paths and I don't need to do an rsync of the FILENAME.yml directory to the '0' directory. If I just copy the yml and env files instead of doing an rsync, it will stop backing up the relative directories twice. Should be an easy change.

That's good news. Thanks for that. Removing relative paths would have almost meant rewriting the docker documentation on the wiki. I'll try to check if the documentation now reflects the behavior of the plugin.

7.1.1 is in the repo now. https://github.com/OpenMediaVa…28aaef2b9029fd8d7ecbdb098

Zitat von ryecoaaron

7.1.1 is in the repo now. https://github.com/OpenMediaVa…28aaef2b9029fd8d7ecbdb098

Many different combinations could be tried. What I have tried works perfectly. Thank you!