but I lost probably a month's work of work because of this.
No action on the GUI, deletes files/folders on the drives EXCEPT if you try to create a FS.
So, explain better what's the issue.
And start by searching the folders on the host, to see if the DATA is still there.
No action on the GUI, deletes files/folders on the drives EXCEPT if you try to create a FS.
So, explain better what's the issue.
And start by searching the folders on the host, to see if the DATA is still there.
It's not in the individual mergerfs folders, I have no idea where else it could have gone. I ran snapraid undelete and got some of the files back, but nowhere near all of them.
I'm currently running snapraid fix to see if that works any better, but I'm not hopeful.
There's too many variables on there (mergerfs, sftp) along the other (snapraid) that you said on the previous posts.
Since I don't use neither, I can't be of much help.
What it show has error is:
ID: unmount_sftp_mountpoint_fa87f20a-2730-476b-b158-e1cdeb37889c
Function: mount.unmounted
Name: /sftp/weanoob/ConvertedMusic
Result: False
Comment: umount: /srv/mergerfs/storage/ConvertedMusic/: not mounted.. Removed target from fstab
Started: 01:27:49.178124
Duration: 26.714 ms
Changes:
----------
persist:
purgedWhat I can tell you is:
Start by listing the individual drive's that compose the mergerfs/sftp point to see if the files are there (they should be):
ls -al /srv/dev-disk-by-uuid-6c31ebf6-7d26-4071-8b32-3ccb3e778487/
ls -al /srv/dev-disk-by-uuid-53d88707-dc91-4726-99e7-610f443f15be/
And so on...
If someone want's to delve deeper, the STACK TRACE is:
ID: remove_openmediavault_dir_fa87f20a-2730-476b-b158-e1cdeb37889c
Function: file.absent
Name: /sftp/weanoob/ConvertedMusic
Result: False
Comment: An exception occurred in this state: Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/salt/modules/file.py", line 4270, in remove
shutil.rmtree(path)
File "/usr/lib/python3.9/shutil.py", line 722, in rmtree
onerror(os.rmdir, path, sys.exc_info())
File "/usr/lib/python3.9/shutil.py", line 720, in rmtree
os.rmdir(path)
OSError: [Errno 16] Device or resource busy: '/sftp/weanoob/ConvertedMusic'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/salt/state.py", line 2401, in call
ret = self.states[cdata["full"]](
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 149, in __call__
return self.loader.run(run_func, *args, **kwargs)
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1234, in run
return self._last_context.run(self._run_as, _func_or_method, *args, **kwargs)
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1249, in _run_as
return _func_or_method(*args, **kwargs)
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1282, in wrapper
return f(*args, **kwargs)
File "/usr/lib/python3/dist-packages/salt/states/file.py", line 1969, in absent
__salt__["file.remove"](name, force=True)
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 149, in __call__
return self.loader.run(run_func, *args, **kwargs)
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1234, in run
return self._last_context.run(self._run_as, _func_or_method, *args, **kwargs)
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1249, in _run_as
return _func_or_method(*args, **kwargs)
File "/usr/lib/python3/dist-packages/salt/modules/file.py", line 4273, in remove
raise CommandExecutionError("Could not remove '{}': {}".format(path, exc))
salt.exceptions.CommandExecutionError: Could not remove '/sftp/weanoob/ConvertedMusic': [Errno 16] Device or resource busy: '/sftp/weanoob/ConvertedMusic'
Started: 01:27:49.205036
Duration: 71.605 ms
Changes:Alles anzeigenThere's too many variables on there (mergerfs, sftp) along the other (snapraid) that you said on the previous posts.
Since I don't use neither, I can't be of much help.
What it show has error is:
CodeAlles anzeigenID: unmount_sftp_mountpoint_fa87f20a-2730-476b-b158-e1cdeb37889c Function: mount.unmounted Name: /sftp/weanoob/ConvertedMusic Result: False Comment: umount: /srv/mergerfs/storage/ConvertedMusic/: not mounted.. Removed target from fstab Started: 01:27:49.178124 Duration: 26.714 ms Changes: ---------- persist: purged
What I can tell you is:
Start by listing the individual drive's that compose the mergerfs/sftp point to see if the files are there (they should be):
ls -al /srv/dev-disk-by-uuid-6c31ebf6-7d26-4071-8b32-3ccb3e778487/ls -al /srv/dev-disk-by-uuid-53d88707-dc91-4726-99e7-610f443f15be/
And so on...
I've basically confirmed that the files are gone, snapraid fix did not restore anything. Where do we go from here?
If you can explain to me how chown and chmod delete files, I would be very impressed. Here are the commands resetperms runs:
Get a massive error, and see that the entire folder is wiped.
How and where are you looking to see these folders are wiped? Sounds like you are looking with a user that doesn't have permissions to see the files after you reset them.
If you can explain to me how chown and chmod delete files, I would be very impressed. Here are the commands resetperms runs:
https://github.com/OpenMediaVa…r/sbin/omv-resetperms#L74
How and where are you looking to see these folders are wiped? Sounds like you are looking with a user that doesn't have permissions to see the files after you reset them.
I have looked using ls -la as a regular user, sudo ls -la as a regular user, and sudo -s followed by ls -la.
I have managed to reproduce the error and can confirm that the files are, in fact, deleted, based on the drive usage shown in the OMV dashboard.
I'm not completely sure what you mean by "where" but I've tried looking in both the mergerfs folder and the individual drives as well.
I went through your steps to reproduce multiple times on two systems and I didn't lose any files or get the error. Have you changed anything python on your system?
I went through your steps to reproduce multiple times on two systems and I didn't lose any files or get the error. Have you changed anything python on your system?
I don't think so, it's using version 3.9.2.
I too can't reproduce this on a brand new VM.
I did change the user/group owning those folders, but I fail to see how that could cause files to be deleted.
Looking at the error again, it is the sftp plugin failing to remove a bind mount because the bind mount is in use. It is an error but it isn't a code issue. I still can't replicate your issue on omv 6 or 7.
did change the user/group owning those folders, but I fail to see how that could cause files to be deleted
None of the steps you listed have delete commands. So, I really don't know what is deleting files.
Looking at the error again, it is the sftp plugin failing to remove a bind mount because the bind mount is in use. It is an error but it isn't a code issue. I still can't replicate your issue on omv 6 or 7.
None of the steps you listed have delete commands. So, I really don't know what is deleting files.
Okay, I managed to recreate the error in a VM. It seems like you have to have the SFTP addon installed, an SFTP share setup for a user with access to the folder. Then you have to change access to No Access, this causes the folder's contents to be deleted; it seems like Reset Permissions actually has nothing to do with it.
I will note that this was also done while replicating my mergerfs/snapraid setup, I'll try it on a bare drive just in case.
Edit: works the same on a bare drive.
It seems like you have to have the SFTP addon installed, an SFTP share setup for a user with access to the folder. Then you have to change access to No Access, this causes the folder's contents to be deleted
Can replicate this. When removing permissions of the user on a share that is used in SFTP data are removed.
This is the message I get
Failed to execute command 'export PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin; export LANG=C.UTF-8; export LANGUAGE=; omv-salt deploy run --no-color fstab 2>&1' with exit code '1': debian:
----------
ID: create_filesystem_mountpoint_d7b45237-5f33-4401-aed9-3fbd7e72e738
Function: file.accumulated
Result: True
Comment: Accumulator create_filesystem_mountpoint_d7b45237-5f33-4401-aed9-3fbd7e72e738 for file /etc/fstab was charged by text
Started: 08:55:35.475859
Duration: 0.637 ms
Changes:
----------
ID: mount_filesystem_mountpoint_d7b45237-5f33-4401-aed9-3fbd7e72e738
Function: mount.mounted
Name: /srv/dev-disk-by-uuid-985a9ff6-d6bb-406a-bdd9-a1260e1fe4e9
Result: True
Comment: Target was already mounted
Started: 08:55:35.477042
Duration: 121.86 ms
Changes:
----------
umount:
Forced remount because options (acl,user_xattr) changed
----------
ID: create_filesystem_mountpoint_eba845e8-8a44-4783-8312-1da06e32e1fe
Function: file.accumulated
Result: True
Comment: Accumulator create_filesystem_mountpoint_eba845e8-8a44-4783-8312-1da06e32e1fe for file /etc/fstab was charged by text
Started: 08:55:35.599023
Duration: 0.673 ms
Changes:
----------
ID: mount_filesystem_mountpoint_eba845e8-8a44-4783-8312-1da06e32e1fe
Function: mount.mounted
Name: /srv/dev-disk-by-uuid-da927c35-368c-44dc-97dc-cf277f839eb8
Result: True
Comment: Target was already mounted
Started: 08:55:35.599789
Duration: 12.084 ms
Changes:
----------
umount:
Forced remount because options (acl,user_xattr) changed
----------
ID: unmount_sftp_mountpoint_3e4aa6ac-d6e4-47c2-b80b-c7a23e5f17ca
Function: mount.unmounted
Name: /sftp/macom/test
Result: False
Comment: umount: /srv/dev-disk-by-uuid-985a9ff6-d6bb-406a-bdd9-a1260e1fe4e9/test/: not mounted.. Removed target from fstab
Started: 08:55:35.611974
Duration: 10.621 ms
Changes:
----------
persist:
purged
----------
ID: remove_openmediavault_dir_3e4aa6ac-d6e4-47c2-b80b-c7a23e5f17ca
Function: file.absent
Name: /sftp/macom/test
Result: False
Comment: An exception occurred in this state: Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/salt/modules/file.py", line 4270, in remove
shutil.rmtree(path)
File "/usr/lib/python3.11/shutil.py", line 738, in rmtree
onerror(os.rmdir, path, sys.exc_info())
File "/usr/lib/python3.11/shutil.py", line 736, in rmtree
os.rmdir(path, dir_fd=dir_fd)
OSError: [Errno 16] Device or resource busy: '/sftp/macom/test'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/salt/state.py", line 2401, in call
ret = self.states[cdata["full"]](
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 149, in __call__
return self.loader.run(run_func, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1234, in run
return self._last_context.run(self._run_as, _func_or_method, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1249, in _run_as
return _func_or_method(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1282, in wrapper
return f(*args, **kwargs)
^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/states/file.py", line 1969, in absent
__salt__["file.remove"](name, force=True)
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 149, in __call__
return self.loader.run(run_func, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1234, in run
return self._last_context.run(self._run_as, _func_or_method, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1249, in _run_as
return _func_or_method(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/modules/file.py", line 4273, in remove
raise CommandExecutionError("Could not remove '{}': {}".format(path, exc))
salt.exceptions.CommandExecutionError: Could not remove '/sftp/macom/test': [Errno 16] Device or resource busy: '/sftp/macom/test'
Started: 08:55:35.622710
Duration: 9.416 ms
Changes:
----------
ID: append_fstab_entries
Function: file.blockreplace
Name: /etc/fstab
Result: True
Comment: No changes needed to be made
Started: 08:55:35.632607
Duration: 2.621 ms
Changes:
----------
ID: fstab_systemctl_daemon_reload
Function: module.run
Result: True
Comment: State was not run because none of the onchanges reqs changed
Started: 08:55:35.635875
Duration: 0.004 ms
Changes:
Summary for debian
------------
Succeeded: 6 (changed=3)
Failed: 2
------------
Total states run: 8
Total run time: 157.916 ms
[ERROR ] Command 'umount' failed with return code: 32
[ERROR ] stderr: umount: /srv/dev-disk-by-uuid-985a9ff6-d6bb-406a-bdd9-a1260e1fe4e9/test/: not mounted.
[ERROR ] retcode: 32
[ERROR ] {'persist': 'purged'}
[ERROR ] An exception occurred in this state: Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/salt/modules/file.py", line 4270, in remove
shutil.rmtree(path)
File "/usr/lib/python3.11/shutil.py", line 738, in rmtree
onerror(os.rmdir, path, sys.exc_info())
File "/usr/lib/python3.11/shutil.py", line 736, in rmtree
os.rmdir(path, dir_fd=dir_fd)
OSError: [Errno 16] Device or resource busy: '/sftp/macom/test'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/salt/state.py", line 2401, in call
ret = self.states[cdata["full"]](
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 149, in __call__
return self.loader.run(run_func, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1234, in run
return self._last_context.run(self._run_as, _func_or_method, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1249, in _run_as
return _func_or_method(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1282, in wrapper
return f(*args, **kwargs)
^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/states/file.py", line 1969, in absent
__salt__["file.remove"](name, force=True)
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 149, in __call__
return self.loader.run(run_func, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1234, in run
return self._last_context.run(self._run_as, _func_or_method, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1249, in _run_as
return _func_or_method(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/modules/file.py", line 4273, in remove
raise CommandExecutionError("Could not remove '{}': {}".format(path, exc))
salt.exceptions.CommandExecutionError: Could not remove '/sftp/macom/test': [Errno 16] Device or resource busy: '/sftp/macom/test'
OMV\ExecException: Failed to execute command 'export PATH=/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin:/usr/local/sbin; export LANG=C.UTF-8; export LANGUAGE=; omv-salt deploy run --no-color fstab 2>&1' with exit code '1': debian:
----------
ID: create_filesystem_mountpoint_d7b45237-5f33-4401-aed9-3fbd7e72e738
Function: file.accumulated
Result: True
Comment: Accumulator create_filesystem_mountpoint_d7b45237-5f33-4401-aed9-3fbd7e72e738 for file /etc/fstab was charged by text
Started: 08:55:35.475859
Duration: 0.637 ms
Changes:
----------
ID: mount_filesystem_mountpoint_d7b45237-5f33-4401-aed9-3fbd7e72e738
Function: mount.mounted
Name: /srv/dev-disk-by-uuid-985a9ff6-d6bb-406a-bdd9-a1260e1fe4e9
Result: True
Comment: Target was already mounted
Started: 08:55:35.477042
Duration: 121.86 ms
Changes:
----------
umount:
Forced remount because options (acl,user_xattr) changed
----------
ID: create_filesystem_mountpoint_eba845e8-8a44-4783-8312-1da06e32e1fe
Function: file.accumulated
Result: True
Comment: Accumulator create_filesystem_mountpoint_eba845e8-8a44-4783-8312-1da06e32e1fe for file /etc/fstab was charged by text
Started: 08:55:35.599023
Duration: 0.673 ms
Changes:
----------
ID: mount_filesystem_mountpoint_eba845e8-8a44-4783-8312-1da06e32e1fe
Function: mount.mounted
Name: /srv/dev-disk-by-uuid-da927c35-368c-44dc-97dc-cf277f839eb8
Result: True
Comment: Target was already mounted
Started: 08:55:35.599789
Duration: 12.084 ms
Changes:
----------
umount:
Forced remount because options (acl,user_xattr) changed
----------
ID: unmount_sftp_mountpoint_3e4aa6ac-d6e4-47c2-b80b-c7a23e5f17ca
Function: mount.unmounted
Name: /sftp/macom/test
Result: False
Comment: umount: /srv/dev-disk-by-uuid-985a9ff6-d6bb-406a-bdd9-a1260e1fe4e9/test/: not mounted.. Removed target from fstab
Started: 08:55:35.611974
Duration: 10.621 ms
Changes:
----------
persist:
purged
----------
ID: remove_openmediavault_dir_3e4aa6ac-d6e4-47c2-b80b-c7a23e5f17ca
Function: file.absent
Name: /sftp/macom/test
Result: False
Comment: An exception occurred in this state: Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/salt/modules/file.py", line 4270, in remove
shutil.rmtree(path)
File "/usr/lib/python3.11/shutil.py", line 738, in rmtree
onerror(os.rmdir, path, sys.exc_info())
File "/usr/lib/python3.11/shutil.py", line 736, in rmtree
os.rmdir(path, dir_fd=dir_fd)
OSError: [Errno 16] Device or resource busy: '/sftp/macom/test'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/salt/state.py", line 2401, in call
ret = self.states[cdata["full"]](
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 149, in __call__
return self.loader.run(run_func, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1234, in run
return self._last_context.run(self._run_as, _func_or_method, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1249, in _run_as
return _func_or_method(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1282, in wrapper
return f(*args, **kwargs)
^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/states/file.py", line 1969, in absent
__salt__["file.remove"](name, force=True)
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 149, in __call__
return self.loader.run(run_func, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1234, in run
return self._last_context.run(self._run_as, _func_or_method, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1249, in _run_as
return _func_or_method(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/modules/file.py", line 4273, in remove
raise CommandExecutionError("Could not remove '{}': {}".format(path, exc))
salt.exceptions.CommandExecutionError: Could not remove '/sftp/macom/test': [Errno 16] Device or resource busy: '/sftp/macom/test'
Started: 08:55:35.622710
Duration: 9.416 ms
Changes:
----------
ID: append_fstab_entries
Function: file.blockreplace
Name: /etc/fstab
Result: True
Comment: No changes needed to be made
Started: 08:55:35.632607
Duration: 2.621 ms
Changes:
----------
ID: fstab_systemctl_daemon_reload
Function: module.run
Result: True
Comment: State was not run because none of the onchanges reqs changed
Started: 08:55:35.635875
Duration: 0.004 ms
Changes:
Summary for debian
------------
Succeeded: 6 (changed=3)
Failed: 2
------------
Total states run: 8
Total run time: 157.916 ms
[ERROR ] Command 'umount' failed with return code: 32
[ERROR ] stderr: umount: /srv/dev-disk-by-uuid-985a9ff6-d6bb-406a-bdd9-a1260e1fe4e9/test/: not mounted.
[ERROR ] retcode: 32
[ERROR ] {'persist': 'purged'}
[ERROR ] An exception occurred in this state: Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/salt/modules/file.py", line 4270, in remove
shutil.rmtree(path)
File "/usr/lib/python3.11/shutil.py", line 738, in rmtree
onerror(os.rmdir, path, sys.exc_info())
File "/usr/lib/python3.11/shutil.py", line 736, in rmtree
os.rmdir(path, dir_fd=dir_fd)
OSError: [Errno 16] Device or resource busy: '/sftp/macom/test'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/salt/state.py", line 2401, in call
ret = self.states[cdata["full"]](
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 149, in __call__
return self.loader.run(run_func, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1234, in run
return self._last_context.run(self._run_as, _func_or_method, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1249, in _run_as
return _func_or_method(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1282, in wrapper
return f(*args, **kwargs)
^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/states/file.py", line 1969, in absent
__salt__["file.remove"](name, force=True)
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 149, in __call__
return self.loader.run(run_func, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1234, in run
return self._last_context.run(self._run_as, _func_or_method, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/loader/lazy.py", line 1249, in _run_as
return _func_or_method(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3/dist-packages/salt/modules/file.py", line 4273, in remove
raise CommandExecutionError("Could not remove '{}': {}".format(path, exc))
salt.exceptions.CommandExecutionError: Could not remove '/sftp/macom/test': [Errno 16] Device or resource busy: '/sftp/macom/test'
in /usr/share/php/openmediavault/system/process.inc:247
Stack trace:
#0 /usr/share/php/openmediavault/engine/module/serviceabstract.inc(62): OMV\System\Process->execute()
#1 /usr/share/openmediavault/engined/rpc/config.inc(186): OMV\Engine\Module\ServiceAbstract->deploy()
#2 [internal function]: Engined\Rpc\Config->applyChanges()
#3 /usr/share/php/openmediavault/rpc/serviceabstract.inc(122): call_user_func_array()
#4 /usr/share/php/openmediavault/rpc/serviceabstract.inc(149): OMV\Rpc\ServiceAbstract->callMethod()
#5 /usr/share/php/openmediavault/rpc/serviceabstract.inc(622): OMV\Rpc\ServiceAbstract->OMV\Rpc\{closure}()
#6 /usr/share/php/openmediavault/rpc/serviceabstract.inc(146): OMV\Rpc\ServiceAbstract->execBgProc()
#7 /usr/share/openmediavault/engined/rpc/config.inc(207): OMV\Rpc\ServiceAbstract->callMethodBg()
#8 [internal function]: Engined\Rpc\Config->applyChangesBg()
#9 /usr/share/php/openmediavault/rpc/serviceabstract.inc(122): call_user_func_array()
#10 /usr/share/php/openmediavault/rpc/rpc.inc(86): OMV\Rpc\ServiceAbstract->callMethod()
#11 /usr/sbin/omv-engined(535): OMV\Rpc\Rpc::call()
#12 {main}I didn't realize the file.absent saltstack function would do a recursive delete on a directory - https://github.com/OpenMediaVa…ploy/fstab/91sftp.sls#L42
But this wouldn't be a problem if the unmount didn't fail right before the code that is deleting the mount directory. I will have to look into why saltstack if still running the delete when the unmount fails.
This whole scenario is something I wouldn't have thought of because you are removing permissions for a shared folder that you are explicitly giving access to in the sftp plugin. This code has been the same for 5+ years (since initial port to OMV 5.x).
I changed the code to use commands that can't delete files. 7.0.2 is in the repo.
I still recommend deleting sftp shares first if you are going to remove privileges for those shares.
I changed the code to use commands that can't delete files. 7.0.2 is in the repo.
https://github.com/OpenMediaVa…05f17b18e56e69b8e14881f46
I still recommend deleting sftp shares first if you are going to remove privileges for those shares.
Right, it's just that it's something really easy to forget about.
Sie haben noch kein Benutzerkonto auf unserer Seite? Registrieren Sie sich kostenlos und nehmen Sie an unserer Community teil!