Error when installing via packages

bchanudet · 30. Juni 2020

Hello,

I've been trying to install omv from the provided package repository (https://packages.openmediavault.org) on a fresh Debian 10 install.

An error occurs when running the postinst script from the openmediavault package:

Code

Setting up openmediavault (5.5.3-1) ...
Creating users/groups ...
Updating local package archive ...
Updating service units ...
systemd-journald.service is a disabled or a static unit, not starting it.
Creating configuration database ...
Setting up Salt environment ...
Setting up system ...
[CRITICAL] Rendering SLS 'base:omv.setup.fstab.default' failed: while parsing a block mapping
  in "<unicode string>", line 66, column 9
did not find expected key
  in "<unicode string>", line 66, column 24
[ERROR   ] {'out': 'highstate', 'ret': {'debian.example.com': ['Rendering SLS \'base:omv.setup.fstab.default\' failed: while parsing a block mapping\n  in "<unicode string>", line 66, column 9\ndid not find expected key\n  in "<unicode string>", line 66, column 24']}}
dpkg: error processing package openmediavault (--configure):
 installed openmediavault package post-installation script subprocess returned error exit status 2
Errors were encountered while processing:
 openmediavault
E: Sub-process /usr/bin/dpkg returned an error code (1)

Alles anzeigen

The server is a server hosted in OVH, with 1x500GB nvme for OS (that's where Debian is stored) and 4x4TB HDD disks that are, for now, unpartitionned (thus unmounted and not even mentioned in /etc/fstab).

I've had a look at the corresponding file, and it seems related to searching for "non rotational" disks, could the fact that I'm running under a nvme disk be the problem here?

I also did an extensive search on Google but I didn't find anything except for some things about the YAML parser and Salt.

Is there someone here that could help me on such an error?

Best regards

votdev · 30. Juni 2020

Maybe this changes will fix your installation problem. These will be included in the next version 5.5.4.

macom · 3. Juli 2020

Zitat von bchanudet

I've been trying to install omv from the provided package repository (https://packages.openmediavault.org) on a fresh Debian 10 install.

Have you tried this approach as well?

https://github.com/OpenMediaVa…-Developers/installScript

bchanudet · 7. Juli 2020

Hello

votdev: wow thanks for the fix, I didn't expect to have something done so quickly. Is there a way for me to test if the fix is good without waiting for the packages database to be updated?

macom I haven't tried it, it seemed at the time more related to "local" installations like on a SBC, whereas I'm trying to install it on a dedicated server in a datacenter. Also from what I'm seeing from the script file, around line 171, it seems to install OMV also from the packages repository, so I think I'll hit the same hurdle by using the script, as the error occurs during the package postinst phase.

In any case thanks for having a look at my problem, I'm eager to look at OMV once I can fix this.

votdev · 7. Juli 2020

bchanudet Please wait until a new package is release if you're not in hurry. Otherwise you can adapt your local files manually according to the github commit.

bchanudet · 15. Juli 2020

Hello votdev

I waited for the new release, and saw today that the 5.5.4-1 package was available on the Github repository.

Unfortunately on my configuration, it didn't fix my problem, and only moved the error line after the 3 you added:

Code

Setting up openmediavault (5.5.4-1) ...
Creating users/groups ...
Updating local package archive ...
Updating service units ...
systemd-journald.service is a disabled or a static unit, not starting it.
Creating configuration database ...
Setting up Salt environment ...
Setting up system ...
[CRITICAL] Rendering SLS 'base:omv.setup.fstab.default' failed: while parsing a block mapping
  in "<unicode string>", line 69, column 9
did not find expected key
  in "<unicode string>", line 69, column 24
[ERROR   ] {'out': 'highstate', 'ret': {'debian.example.com': ['Rendering SLS \'base:omv.setup.fstab.default\' failed: while parsing a block mapping\n  in "<unicode string>", line 69, column 9\ndid not find expected key\n  in "<unicode string>", line 69, column 24']}}
dpkg: error processing package openmediavault (--configure):
 installed openmediavault package post-installation script subprocess returned error exit status 2
Errors were encountered while processing:
 openmediavault
E: Sub-process /usr/bin/dpkg returned an error code (1)

Alles anzeigen

Here are more information if it can help:

Code

$ sudo cat /etc/fstab
UUID="9f51e591-9764-4476-91d5-e4df1cc7cb78" / ext4 defaults 0 0
UUID="a683543e-f827-41e3-a145-aa68e1922057" swap swap defaults 0 0
LABEL=EFI_SYSPART /boot/efi vfat defaults 0 0

Code

$ sudo lsblk -a
NAME        MAJ:MIN RM  SIZE RO TYPE MOUNTPOINT
sda           8:0    0  3.7T  0 disk
sdb           8:16   0  3.7T  0 disk
sdc           8:32   0  3.7T  0 disk
sdd           8:48   0  3.7T  0 disk
nvme0n1     259:0    0  477G  0 disk
├─nvme0n1p1 259:1    0  511M  0 part /boot/efi
├─nvme0n1p2 259:2    0  476G  0 part /
├─nvme0n1p3 259:3    0  511M  0 part [SWAP]
└─nvme0n1p4 259:4    0    1M  0 part

Alles anzeigen

Code

$ sudo salt-call mount.fstab
local:
    ----------
    /:
        ----------
        device:
            UUID="9f51e591-9764-4476-91d5-e4df1cc7cb78"
        dump:
            0
        fstype:
            ext4
        opts:
            - defaults
        pass:
            0
    /boot/efi:
        ----------
        device:
            LABEL=EFI_SYSPART
        dump:
            0
        fstype:
            vfat
        opts:
            - defaults
        pass:
            0
    swap:
        ----------
        device:
            UUID="a683543e-f827-41e3-a145-aa68e1922057"
        dump:
            0
        fstype:
            swap
        opts:
            - defaults
        pass:
            0

Alles anzeigen

I enabled the debug logging on the Salt minion but nothing more related to this error appears in the logfile so I don't think it'll help. I'd be happy to help debug it in any way I can.

Do tell if you want me to open a Github Issue instead for better tracking of this beast.

votdev · 15. Juli 2020

I really have no idea what is going wrong here. The error message is not really helpful because line 69 is module.run:.

bchanudet · 15. Juli 2020

Hello votdev,

I kept investigating on this bug as it prevents me to finish the setup of my OVH server, and I think I found the origin of the issue.

As you can see on my sudo salt-call mount.fstab, my root partition is defined on the device UUID="9f51e591-9764-4476-91d5-e4df1cc7cb78". And I think you'll see where the problem is if I highlight that this string has quotes.

I ran through my debug log of salt minion and found the rendered YAML of the default.sls file:

Code

# This file is part of OpenMediaVault.
#
# @license   http://www.gnu.org/licenses/gpl.html GPL Version 3
# @author    Volker Theile <volker.theile@openmediavault.org>
# @copyright Copyright (c) 2009-2020 Volker Theile
#
# OpenMediaVault is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# any later version.
#
# OpenMediaVault is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with OpenMediaVault. If not, see <http://www.gnu.org/licenses/>.

# Documentation/Howto:
# http://linux.koolsolutions.com/2009/01/30/installing-linux-on-usb-part-4-noatime-and-relatime-mount-options/
# http://techgage.com/article/enabling_and_testing_ssd_trim_support_under_linux
# https://wiki.archlinux.org/index.php/Solid_State_Drives
# http://wiki.ubuntuusers.de/SSD/TRIM
# http://superuser.com/questions/228657/which-linux-filesystem-works-best-with-ssd



# Reload udev rules to apply rules shipped with openmediavault, e.g.
# to detect non-rotational devices.
udevadm_reload_rules:
  cmd.run:
    - name: "udevadm control --reload-rules"

udevadm_trigger:
  cmd.run:
    - name: "udevadm trigger"
    - onchanges:
      - udevadm_reload_rules




# Get the mount configuration for the root filesystem.
# {
#   "device": "UUID=199a4bbc-59c9-4a3b-b592-950eaffb2530",
#   "pass": "1",
#   "opts": [
#     "errors=remount-ro"
#   ],
#   "dump": "0",
#   "fstype": "ext4"
# }

# Get the device file of the root filesystem.




# Get the parent device file of the root filesystem.




update_root_fstab_entry:
  module.run:
    - mount.set_fstab:
      - name: "/"
      - device: "UUID="9f51e591-9764-4476-91d5-e4df1cc7cb78""
      - fstype: "ext4"
      - opts: "noatime,nodiratime,defaults"
      - dump: "0"
      - pass_num: "0"

Alles anzeigen

As you can see, and as Yaml online parser confirms, as the quotes are not escaped in the rendered YAML, the parsing fails completely and the script doesn't go further.

As I see it, I have two ways to fix it:

- Either change my /etc/fstab initial file to use something else than the UUID to describe my entries.

- Or change the sls file to handle output from mount.fstab that contain quotes.

Given that using UUIDs in /etc/fstab is not unusual, I think the latter is the better solution. If you want, I could go on and send a PR your way once I remind myself with Jinja and Yaml and find how to fix it.

Best regards

ryecoaaron · 15. Juli 2020

Zitat von bchanudet

Given that using UUIDs in /etc/fstab is not unusual,

While I agree the code should be fixed to handle the quotes, the default OMV install does not use quotes around the UUID in fstab. If you just remove the quotes, I would guess your system would be fine.

bchanudet · 15. Juli 2020

Hello ryecoaaron,

You are right, when I wrote my message I had forgotten that UUIDs can be used without quotes in fstab. That's actually what I ended up doing, and I can confirm the installation goes to completion afterwards.

In a way we could blame all of this on the error message of the YAML parser that was very cryptic and not helpful at all. Being a developer myself I get so frustrated when you have such error messages. To think that, if the message mentioned the quotes, this thread wouldn't have existed... Oh well.

Sorry for the inconvenience, votdev you can still tell me if you'd like a PR from me, I'd be glad to have a go at it

Best regards,

votdev · 15. Juli 2020

bchanudet Thanks for helping to investigate this issue. I've fixed it with https://github.com/openmediava…c2ad68838d4e3116d9821bc56.

Jetzt mitmachen!